test_integration.py: generated SQL test needs CREATE TABLE to validate #149
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/hottea#149
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
tests/test_integration.py:121-141—test_generated_sql_is_valid_sqlite3runssqlite3 :memory: .readon generated SQL, but there's noCREATE TABLE action (...)statement. The INSERT will fail with "no such table: action" if sqlite3 is installed.The test is silently skipped on systems without sqlite3, only manifesting as a failure when sqlite3 IS present.
Fix: either create the table in the SQL before validating, or add a CREATE TABLE statement to the generated SQL being tested.
Ref: PR #148