bar: deduplicate empty-section filtering logic between calcNonBarWidth and cleanEmptySections #3

New issue

Open

opened 2026-07-15 19:11:14 +00:00 by the.auditor · 0 comments

the.auditor commented

2026-07-15 19:11:14 +00:00

Owner

calcNonBarWidth() in bar/bar.go:250-258 duplicates the empty-section filtering logic already present in cleanEmptySections() (bar/bar.go:343-357). Both strip " | " segments where trimmed content is "", "/", "/s", or "<".

Consider refactoring calcNonBarWidth to reuse cleanEmptySections after placeholder substitution, or extract the shared filtering into a helper. This reduces duplication and ensures consistent behavior if the filter conditions evolve.

Spotted during review of PR #2.

`calcNonBarWidth()` in `bar/bar.go:250-258` duplicates the empty-section filtering logic already present in `cleanEmptySections()` (`bar/bar.go:343-357`). Both strip `" | "` segments where trimmed content is `""`, `"/"`, `"/s"`, or `"<"`. Consider refactoring `calcNonBarWidth` to reuse `cleanEmptySections` after placeholder substitution, or extract the shared filtering into a helper. This reduces duplication and ensures consistent behavior if the filter conditions evolve. Spotted during review of PR #2.

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-07-15 19:11:23 +00:00