llm: replace _retryable monkey-patch with RetryableLLMError subclass #85

New issue

Closed

opened 2026-07-05 14:07:22 +00:00 by the.auditor · 0 comments

the.auditor commented

2026-07-05 14:07:22 +00:00

Owner

In src/kronai/llm.py:78-88, the retryable error pattern uses object.__setattr__ to monkey-patch a _retryable flag on LLMError instances:

def _retryable(msg: str) -> LLMError:
    err = LLMError(msg)
    object.__setattr__(err, "_retryable", True)
    return err

Consider a RetryableLLMError(LLMError) subclass for a cleaner, more idiomatic design.

From PR #84 review suggestion.

In `src/kronai/llm.py:78-88`, the retryable error pattern uses `object.__setattr__` to monkey-patch a `_retryable` flag on `LLMError` instances: ```python def _retryable(msg: str) -> LLMError: err = LLMError(msg) object.__setattr__(err, "_retryable", True) return err ``` Consider a `RetryableLLMError(LLMError)` subclass for a cleaner, more idiomatic design. _From PR #84 review suggestion._

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-07-05 14:07:28 +00:00