thwap/pget
Watch
4
0
Fork
You've already forked pget
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(http): implement HTTP client with context, timeouts, and cookie jar #127

Merged
fuzzy merged 2 commits from feat/http-client into main 2026-07-13 17:30:28 +00:00
Conversation 1 Commits 2 Files changed 2 +49 -4
automation commented 2026-07-13 17:27:30 +00:00
Owner
Copy link

What

Create HTTP client wrapper in internal/downloader with context support, configurable timeouts, custom User-Agent headers, and a cookie jar.

Why

Foundation for HTTP download functionality — all HTTP requests will go through this client.

Testing

  • go vet ./... passes
  • go build ./... passes
  • golangci-lint run ./... passes
  • Pre-commit hooks pass

Breaking Changes

None

Notes

  • Client timeout sourced from Config.Timeout
  • Transport configured with ResponseHeaderTimeout and IdleConnTimeout
  • Cookie jar initialized via net/http/cookiejar for future session support
  • NewRequest() helper sets User-Agent from config, creates request with context

Closes #0023
Closes #0024
Closes #0025
Closes #0026

## What Create HTTP client wrapper in `internal/downloader` with context support, configurable timeouts, custom User-Agent headers, and a cookie jar. ## Why Foundation for HTTP download functionality — all HTTP requests will go through this client. ## Testing - [x] `go vet ./...` passes - [x] `go build ./...` passes - [x] `golangci-lint run ./...` passes - [x] Pre-commit hooks pass ## Breaking Changes None ## Notes - Client timeout sourced from `Config.Timeout` - Transport configured with `ResponseHeaderTimeout` and `IdleConnTimeout` - Cookie jar initialized via `net/http/cookiejar` for future session support - `NewRequest()` helper sets User-Agent from config, creates request with context Closes #0023 Closes #0024 Closes #0025 Closes #0026
Closes #0023 Closes #0024 Closes #0025 Closes #0026
docs(roadmap): mark HTTP client complete
All checks were successful
Test and Release / test (pull_request) Successful in 2m1s
Details
Test and Release / lint (pull_request) Successful in 2m54s
Details
5fb4975be7
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-13 17:28:02 +00:00
the.auditor approved these changes 2026-07-13 17:28:46 +00:00
the.auditor left a comment
Copy link

Review: APPROVED

Verification

  • go vet ./... — ✅ passes
  • go build ./... — ✅ passes
  • golangci-lint v2 run ./... — ✅ 0 issues

Changes

  • internal/downloader/client.go (new) — HTTP client wrapper with timeouts, transport config, cookie jar, User-Agent
  • ROADMAP.md — Marks Phase 2 HTTP client items as [x]

Suggestions (non-blocking)

  • #128 — NewRequest requires cfg again; store userAgent on Client struct
  • #129 — Missing tests for downloader/client.go

Closes #0023, #0024, #0025, #0026 on merge.

## Review: APPROVED ### Verification - `go vet ./...` — ✅ passes - `go build ./...` — ✅ passes - `golangci-lint v2 run ./...` — ✅ 0 issues ### Changes - `internal/downloader/client.go` (new) — HTTP client wrapper with timeouts, transport config, cookie jar, User-Agent - `ROADMAP.md` — Marks Phase 2 HTTP client items as [x] ### Suggestions (non-blocking) - #128 — `NewRequest` requires `cfg` again; store userAgent on Client struct - #129 — Missing tests for downloader/client.go Closes #0023, #0024, #0025, #0026 on merge.
fuzzy merged commit 5fb4975be7 into main 2026-07-13 17:30:28 +00:00
fuzzy deleted branch feat/http-client 2026-07-13 17:30:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/pget!127
No description provided.