fix(downloader): SplitChunks produces invalid Range header for zero-size file #131

New issue

Closed

opened 2026-07-13 17:50:24 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-07-13 17:50:24 +00:00

Owner

internal/downloader/range.go:64-65 — SplitChunks(0, n) returns [{Start: 0, End: 0}], producing BuildRangeHeader output bytes=0--1 which is an invalid HTTP Range header.

For zero-size files, SplitChunks should return an empty slice — no chunks needed for an empty file. The caller should check FileInfo.Size == 0 before initiating chunked download.

if fileSize <= 0 {
    return nil
}

Discovered during review of PR #130.

`internal/downloader/range.go:64-65` — `SplitChunks(0, n)` returns `[{Start: 0, End: 0}]`, producing `BuildRangeHeader` output `bytes=0--1` which is an invalid HTTP Range header. For zero-size files, `SplitChunks` should return an empty slice — no chunks needed for an empty file. The caller should check `FileInfo.Size == 0` before initiating chunked download. ```go if fileSize <= 0 { return nil } ``` Discovered during review of PR #130.

the.auditor added the

Kind/Bug

Priority

Low

labels

2026-07-13 17:50:29 +00:00

automation commented

2026-07-15 17:15:43 +00:00

Owner

Closing — implemented in PR #165. SplitChunks returns nil for fileSize <= 0, Download() handles empty chunks as zero-size file (no-op).

Closing — implemented in PR #[165](https://git.lan.thwap.org/thwap/pget/pulls/165). SplitChunks returns nil for fileSize <= 0, Download() handles empty chunks as zero-size file (no-op).

automation closed this issue

2026-07-15 17:15:49 +00:00