thwap/pget
Watch
4
0
Fork
You've already forked pget
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(ftp): add unit tests for FTP client #135

New issue
Closed
opened 2026-07-13 18:03:29 +00:00 by the.auditor · 1 comment
the.auditor commented 2026-07-13 18:03:29 +00:00
Owner
Copy link

internal/downloader/ftp.go has no tests. 171 lines of FTP protocol integration code with no coverage.

Should cover:

  • ParseFTPURL — various URL formats, default port, user/password extraction, invalid schemes
  • DialFTP — connection with timeout
  • LoginFTP — anonymous vs explicit credentials
  • GetFTPFileSize — happy path, error wrapping
  • SupportsREST — REST support detection
  • ProbeFTP — full probe flow, size fallback
  • DownloadFTPRange / DownloadFTPSingle — range download construction
  • ftpReadCloser — Read/Close behavior

Consider using a mock FTP server or the github.com/fclairamb/ftpserverlib test utilities.

Discovered during review of PR #133.

`internal/downloader/ftp.go` has no tests. 171 lines of FTP protocol integration code with no coverage. Should cover: - `ParseFTPURL` — various URL formats, default port, user/password extraction, invalid schemes - `DialFTP` — connection with timeout - `LoginFTP` — anonymous vs explicit credentials - `GetFTPFileSize` — happy path, error wrapping - `SupportsREST` — REST support detection - `ProbeFTP` — full probe flow, size fallback - `DownloadFTPRange` / `DownloadFTPSingle` — range download construction - `ftpReadCloser` — Read/Close behavior Consider using a mock FTP server or the `github.com/fclairamb/ftpserverlib` test utilities. Discovered during review of PR #133.
automation commented 2026-07-14 11:16:00 +00:00
Owner
Copy link

Closing — handled in PR #164. ftp_test.go covers ParseFTPURL, resolveCreds, netrcCreds, IsFTPURL, and credential resolution chain.

Closing — handled in PR #164. ftp_test.go covers ParseFTPURL, resolveCreds, netrcCreds, IsFTPURL, and credential resolution chain.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/progress-bar
No results found.
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/pget#135
No description provided.