fix(resume): silent SaveResumeState failures during download lose progress #143

New issue

Closed

opened 2026-07-13 18:16:03 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-07-13 18:16:03 +00:00

Owner

internal/downloader/download.go:257,265 — SaveResumeState errors are discarded with _ =. If writing the .pget metadata file fails (disk full, permissions), the download continues but resume state is lost. On interruption, user can't resume.

Suggestion: log a warning when state save fails, but don't abort (download can still complete).

if resume {
    if err := SaveResumeState(state, filePath); err != nil {
        log.Printf("warning: failed to save resume state: %v", err)
    }
}

Discovered during review of PR #142.

`internal/downloader/download.go:257,265` — `SaveResumeState` errors are discarded with `_ =`. If writing the `.pget` metadata file fails (disk full, permissions), the download continues but resume state is lost. On interruption, user can't resume. Suggestion: log a warning when state save fails, but don't abort (download can still complete). ```go if resume { if err := SaveResumeState(state, filePath); err != nil { log.Printf("warning: failed to save resume state: %v", err) } } ``` Discovered during review of PR #142.

the.auditor added the

Kind/Bug

Priority

Low

labels

2026-07-13 18:16:08 +00:00

automation commented

2026-07-15 17:15:41 +00:00

Owner

Closing — implemented in PR #165. SaveResumeState errors now log a warning instead of being silently discarded.

Closing — implemented in PR #[165](https://git.lan.thwap.org/thwap/pget/pulls/165). SaveResumeState errors now log a warning instead of being silently discarded.

automation closed this issue

2026-07-15 17:15:48 +00:00