test(resume): add unit tests for resume state management #144

New issue

Closed

opened 2026-07-13 18:16:05 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-07-13 18:16:05 +00:00

Owner

internal/downloader/resume.go has no tests. 112 lines of serialization/deserialization, file I/O, and thread-safe state management with zero coverage.

Should cover:

SaveResumeState — writes valid JSON to .pget file
LoadResumeState — loads valid state, handles missing file, corrupted JSON, size mismatch, chunk count mismatch
IsDone — returns correct status for completed/incomplete chunks
MarkDone — marks chunk, thread safety
VerifyFileSize — exact match, mismatch, stat error
CleanupResumeState — removes file
metaPath — correct path generation
Round-trip: save → load → verify all chunks marked as done
Integration with Download(): state saved after each chunk, cleaned up on success, preserved on failure

Discovered during review of PR #142.

`internal/downloader/resume.go` has no tests. 112 lines of serialization/deserialization, file I/O, and thread-safe state management with zero coverage. Should cover: - `SaveResumeState` — writes valid JSON to `.pget` file - `LoadResumeState` — loads valid state, handles missing file, corrupted JSON, size mismatch, chunk count mismatch - `IsDone` — returns correct status for completed/incomplete chunks - `MarkDone` — marks chunk, thread safety - `VerifyFileSize` — exact match, mismatch, stat error - `CleanupResumeState` — removes file - `metaPath` — correct path generation - Round-trip: save → load → verify all chunks marked as done - Integration with `Download()`: state saved after each chunk, cleaned up on success, preserved on failure Discovered during review of PR #142.

the.auditor added the

Kind/Testing

Priority

Medium

labels

2026-07-13 18:16:09 +00:00

automation commented

2026-07-14 11:15:59 +00:00

Owner

Closing — implemented in PR #164. Tests added for config, logging, HTTP client, FTP client, and resume state management.

Closing — implemented in PR #[164](https://git.lan.thwap.org/thwap/pget/pulls/164). Tests added for config, logging, HTTP client, FTP client, and resume state management.

automation closed this issue

2026-07-14 11:16:07 +00:00