cli.lua: "already installed" feedback not visible without --verbose #309
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/qpkg#309
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In PR #308,
cli.lua:311-312was changed fromio.stderr:write(always visible) tolog.info(only visible with--verbose). At this point incommands.install,log.open()hasn't been called yet, so the message is also not written to the log file.Users running
qpkg install <pkg>on an already-installed package get exit code 0 with zero output. Consider usinglog.warn(always visible) or addinglog.set_verbose(true)for this specific path.Ref: PR #308 review
Also noted in PR #311 review:
cli.lua:311-312"already installed" path still useslog.info(silent without--verbose). This remains unaddressed from PR #308.