cli.lua: "already installed" feedback not visible without --verbose #309

Closed
opened 2026-07-09 19:40:02 +00:00 by the.auditor · 1 comment
Owner

In PR #308, cli.lua:311-312 was changed from io.stderr:write (always visible) to log.info (only visible with --verbose). At this point in commands.install, log.open() hasn't been called yet, so the message is also not written to the log file.

Users running qpkg install <pkg> on an already-installed package get exit code 0 with zero output. Consider using log.warn (always visible) or adding log.set_verbose(true) for this specific path.

Ref: PR #308 review

In PR #308, `cli.lua:311-312` was changed from `io.stderr:write` (always visible) to `log.info` (only visible with `--verbose`). At this point in `commands.install`, `log.open()` hasn't been called yet, so the message is also not written to the log file. Users running `qpkg install <pkg>` on an already-installed package get exit code 0 with zero output. Consider using `log.warn` (always visible) or adding `log.set_verbose(true)` for this specific path. Ref: PR #308 review
Author
Owner

Also noted in PR #311 review: cli.lua:311-312 "already installed" path still uses log.info (silent without --verbose). This remains unaddressed from PR #308.

Also noted in PR #311 review: `cli.lua:311-312` "already installed" path still uses `log.info` (silent without `--verbose`). This remains unaddressed from PR #308.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/qpkg#309
No description provided.