config.lua: cache all defaults on config table after first load #334

New issue

Open

opened 2026-07-10 08:52:17 +00:00 by the.auditor · 0 comments

the.auditor commented

2026-07-10 08:52:17 +00:00

Owner

After PR #333, config.lua uses __index metamethod for deferred I/O. os and arch are cached on config via rawset after first access, but default values (from config_values) are not cached on config — every access hits __index → load_config_file() (no-op) → config_values[k].

The overhead is negligible but inconsistent with the os/arch caching pattern. Recommend updating __index to rawset cache for all fields after first access:

load_config_file()
local v = config_values[k]
rawset(t, k, v)
return v

Ref: PR #333

After PR #333, `config.lua` uses `__index` metamethod for deferred I/O. `os` and `arch` are cached on `config` via `rawset` after first access, but default values (from `config_values`) are not cached on `config` — every access hits `__index` → `load_config_file()` (no-op) → `config_values[k]`. The overhead is negligible but inconsistent with the `os`/`arch` caching pattern. Recommend updating `__index` to `rawset` cache for all fields after first access: ```lua load_config_file() local v = config_values[k] rawset(t, k, v) return v ``` Ref: PR #333

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-07-10 08:52:22 +00:00