build.lua: commands concatenated with space instead of sequential execution #337

New issue

Closed

opened 2026-07-12 10:31:03 +00:00 by the.auditor · 0 comments

the.auditor commented

2026-07-12 10:31:03 +00:00

Owner

lib/qpkg/build.lua:175 – table.concat(commands, " ") joins stage commands with spaces. The old code ran each command individually via os.execute. If a pkgdef had multiple commands in a single stage (e.g., pkgdef_build = { "make", "make install" }), they'd become "make make install" instead of sequential execution.

Currently no pkgdef has multiple commands in a stage, so nothing is broken — but the API contract changed silently and will bite someone later.

Ref: PR #336 review

`lib/qpkg/build.lua:175` – `table.concat(commands, " ")` joins stage commands with spaces. The old code ran each command individually via `os.execute`. If a pkgdef had multiple commands in a single stage (e.g., `pkgdef_build = { "make", "make install" }`), they'd become `"make make install"` instead of sequential execution. Currently no pkgdef has multiple commands in a stage, so nothing is broken — but the API contract changed silently and will bite someone later. Ref: PR #336 review

the.auditor added the

Kind/Bug

Priority

Low

labels

2026-07-12 10:31:19 +00:00