refactor(homeview): extract formatDesc into testable method #165
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/steeper#165
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
formatDescis a closure insideHomeView.renderActivities(), which makes it impossible to unit test the activity description formatting logic. This was highlighted by PR #164 which added issue event formatting — no tests could be written for the new logic.Suggestion: extract
formatDescinto a standalone method onHomeView(or a package-level function) so the formatting logic can be tested with table-driven tests.Ref: PR #164