test(activity): add missing sparkline rendering unit tests #327

Merged

fuzzy merged 1 commit from phase08-sparkline-tests into main

2026-07-07 21:26:45 +00:00

automation commented

2026-07-07 21:16:56 +00:00

Owner

What

Add missing unit tests for sparkline rendering, completing #274.

New tests

BrailleDualCharAllLevels — verifies all 5 levels (0-4) produce distinct Braille characters (U+2800-U+28FF)
DualBrailleSparklineMaxValues — tests that max values produce non-empty characters at full level

Fix

DualBrailleSparkline level mapping: changed from /2 (capped at 3) to *4/7 (maps 0-7 to 0-4), enabling all 5 Braille levels
Removed unreachable clamping code (normalize always returns 0-7, *4/7 always maps to 0-4)

Coverage

Metric	Before	After
Renderer functions	84-100%	100%
Package total	91.9%	93.2%

References: #274, #271, #272, #273

Testing

3 new subtests + existing 33 = all pass
go test -race ./... — all pass

## What Add missing unit tests for sparkline rendering, completing #274. ### New tests - **BrailleDualCharAllLevels** — verifies all 5 levels (0-4) produce distinct Braille characters (U+2800-U+28FF) - **DualBrailleSparklineMaxValues** — tests that max values produce non-empty characters at full level ### Fix - **DualBrailleSparkline level mapping**: changed from `/2` (capped at 3) to `*4/7` (maps 0-7 to 0-4), enabling all 5 Braille levels - Removed unreachable clamping code (normalize always returns 0-7, `*4/7` always maps to 0-4) ### Coverage | Metric | Before | After | |--------|--------|-------| | Renderer functions | 84-100% | **100%** | | Package total | 91.9% | **93.2%** | References: #274, #271, #272, #273 ## Testing - [x] 3 new subtests + existing 33 = all pass - [x] `go test -race ./...` — all pass

automation added 1 commit

2026-07-07 21:16:56 +00:00

test(activity): add missing sparkline rendering unit tests

Test and Release / lint (pull_request) Successful in 3m49s

Details

Test and Release / test (pull_request) Successful in 9m46s

Details

4eee1c112e

- BrailleDualCharAllLevels: verifies all 5 levels (0-4) produce
  distinct Braille characters
- DualBrailleSparklineMaxValues: tests that max values produce
  non-empty characters at full level
- DualBrailleSparkline: fixed level mapping (0-7 → 0-4 via *4/7
  instead of /2 which capped at 3)
- Removed unreachable clamping code (normalize always returns 0-7,
  *4/7 always maps to 0-4)
- All renderer functions now at 100% statement coverage
- Package coverage: 93.2%

Ref: #274, #271, #272, #273

fuzzy added this to the Steeper project

2026-07-07 21:17:27 +00:00

fuzzy self-assigned this

2026-07-07 21:17:31 +00:00

the.auditor approved these changes

2026-07-07 21:17:42 +00:00

the.auditor left a comment

Review

Result: Approved — no blocking issues. Fixes #303 (dead level-4 code).

Summary: Fixes DualBrailleSparkline level mapping from /2 (capped at 3) to *4/7 (maps 0-7 to 0-4), enabling all 5 Braille levels. Removes 12 lines of unreachable clamping code. Adds 3 tests: all 5 levels produce distinct chars, max values produce non-empty chars, first char in rising sequence is U+2800. Coverage: 91.9% → 93.2%. ROADMAP2.md updated.

Checklist:

Correctness: ✅ *4/7 integer math correctly maps 0-7 to 0-4, all 5 levels reachable
Completeness: ✅ Closes #274 — Braille mapping, normalization, empty data all covered
Test coverage: ✅ 3 new subtests (max values, all levels distinct, rising baseline)
Race-safe: ✅ go test -race passes
Maintainability: ✅ Simpler code — no clamping branches

## Review **Result: Approved** — no blocking issues. Fixes #303 (dead level-4 code). **Summary:** Fixes `DualBrailleSparkline` level mapping from `/2` (capped at 3) to `*4/7` (maps 0-7 to 0-4), enabling all 5 Braille levels. Removes 12 lines of unreachable clamping code. Adds 3 tests: all 5 levels produce distinct chars, max values produce non-empty chars, first char in rising sequence is U+2800. Coverage: 91.9% → 93.2%. ROADMAP2.md updated. **Checklist:** - Correctness: ✅ `*4/7` integer math correctly maps 0-7 to 0-4, all 5 levels reachable - Completeness: ✅ Closes #274 — Braille mapping, normalization, empty data all covered - Test coverage: ✅ 3 new subtests (max values, all levels distinct, rising baseline) - Race-safe: ✅ `go test -race` passes - Maintainability: ✅ Simpler code — no clamping branches

fuzzy scheduled this pull request to auto merge when all checks succeed

2026-07-07 21:17:59 +00:00

fuzzy merged commit 4eee1c112e into main

2026-07-07 21:26:45 +00:00

fuzzy deleted branch phase08-sparkline-tests

2026-07-07 21:26:46 +00:00

automation referenced this pull request

2026-07-07 21:36:02 +00:00

docs: update documentation for activity view feature #329