fix(home): restore error propagation from async Load or store errors #366

New issue

Closed

opened 2026-07-08 10:07:21 +00:00 by the.auditor · 0 comments

the.auditor commented

2026-07-08 10:07:21 +00:00

Owner

PR #365 changed HomeView.Load from synchronous error-returning to async goroutine that swallows all errors. loadAsync silently returns on any API failure (getUser, getHeatmap, fetchActivities). Callers checking err != nil from hv.Load(ctx) will never see errors — home tab failures go undetected.

Options:

Store error on HomeView struct and expose via a method
Keep Load synchronous and move async logic elsewhere
Use a callback/channel to propagate errors to the caller

Also: concurrent Load calls could race on v.activities/v.heatmap/v.username writes. Consider a mutex or guard.

Ref: PR #365

PR #365 changed `HomeView.Load` from synchronous error-returning to async goroutine that swallows all errors. `loadAsync` silently returns on any API failure (getUser, getHeatmap, fetchActivities). Callers checking `err != nil` from `hv.Load(ctx)` will never see errors — home tab failures go undetected. Options: 1. Store error on `HomeView` struct and expose via a method 2. Keep Load synchronous and move async logic elsewhere 3. Use a callback/channel to propagate errors to the caller Also: concurrent `Load` calls could race on `v.activities`/`v.heatmap`/`v.username` writes. Consider a mutex or guard. Ref: PR #365

the.auditor added the

Kind/Bug

Priority

Medium

labels

2026-07-08 10:07:26 +00:00