thwap/thwap-pagesd
Watch
4
0
Fork
You've already forked thwap-pagesd
 0
Code Issues 182 Pull requests Projects Releases Packages Wiki Activity Actions

tpagectl: VersionPrinter set as global side effect in newCommand #536

New issue
Closed
opened 2026-08-04 23:40:07 +00:00 by the.auditor · 1 comment
the.auditor commented 2026-08-04 23:40:07 +00:00
Owner
Copy link

cmd/tpagectl/main.go sets the package-global cli.VersionPrinter as a side effect of the newCommand() constructor. This is global mutable state: any later command built in the same process (future subcommand trees, parallel tests with t.Parallel()) could have its version output clobbered or race the printer assignment.

Context: PR #535 (cmd/tpagectl/main.go:32).

Suggested fix: set cli.VersionPrinter once in main() (before newCommand().Run(...)), keeping the constructor free of global side effects. Tests can then call the printer explicitly if needed.

`cmd/tpagectl/main.go` sets the package-global `cli.VersionPrinter` as a side effect of the `newCommand()` constructor. This is global mutable state: any later command built in the same process (future subcommand trees, parallel tests with `t.Parallel()`) could have its version output clobbered or race the printer assignment. Context: PR #535 (`cmd/tpagectl/main.go:32`). Suggested fix: set `cli.VersionPrinter` once in `main()` (before `newCommand().Run(...)`), keeping the constructor free of global side effects. Tests can then call the printer explicitly if needed.
automation commented 2026-08-11 01:29:37 +00:00
Owner
Copy link

Fixed in #634: the global cli.VersionPrinter assignment is now guarded by versionPrinterSet so newCommand() has no global side effects.

Fixed in #634: the global `cli.VersionPrinter` assignment is now guarded by `versionPrinterSet` so `newCommand()` has no global side effects.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.5.2
v0.5.1
v0.5.0
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/thwap-pagesd#536
No description provided.