tpagectl: output and 404 helpers duplicated across site and deployment #565

New issue

Closed

opened 2026-08-06 03:46:42 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-06 03:46:42 +00:00

Owner

internal/tpagectl/deployment/list.go re-implements helpers already present in internal/tpagectl/site:

printTable / writeJSON / writeYAML + the --format dispatch switch are duplicated between the site and deployment packages
the 404-to-friendly-message mapping is now a fourth inline copy (extends #561)

Suggested fix: extract shared output rendering (table/json/yaml) and the friendlyNotFound helper into a shared package (e.g. internal/tpagectl/output) used by both command groups.

Ref: PR #564

`internal/tpagectl/deployment/list.go` re-implements helpers already present in `internal/tpagectl/site`: - `printTable` / `writeJSON` / `writeYAML` + the `--format` dispatch switch are duplicated between the `site` and `deployment` packages - the 404-to-friendly-message mapping is now a fourth inline copy (extends #561) Suggested fix: extract shared output rendering (table/json/yaml) and the `friendlyNotFound` helper into a shared package (e.g. `internal/tpagectl/output`) used by both command groups. Ref: PR #564

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-08-06 03:46:47 +00:00

fuzzy referenced this issue from a commit

2026-08-11 12:32:47 +00:00

test(tpagectl): close tests-lump audit gaps

automation referenced this issue

2026-08-11 12:32:52 +00:00

test(tpagectl): close tests-lump audit gaps #635

fuzzy referenced this issue from a commit

2026-08-11 12:36:02 +00:00

test(tpagectl): close tests-lump audit gaps

automation closed this issue

2026-08-11 12:36:17 +00:00

automation commented

2026-08-11 12:36:18 +00:00

Owner

Fixed in #635: output.RenderFormat centralizes the --format dispatch (json/yaml/table + validation error) shared by site list/site get and deployment list/deployment get; the 404 mapping is centralized in clierr.NotFoundf. Type-specific row building stays local in each package's printTable.

Fixed in #635: `output.RenderFormat` centralizes the `--format` dispatch (json/yaml/table + validation error) shared by `site list`/`site get` and `deployment list`/`deployment get`; the 404 mapping is centralized in `clierr.NotFoundf`. Type-specific row building stays local in each package's `printTable`.