tpagectl: deployment promote swallows site-status URL fetch error #569

New issue

Closed

opened 2026-08-06 05:43:40 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-06 05:43:40 +00:00

Owner

In runPromote (internal/tpagectl/deployment/promote.go), the site-status GET used to fetch the URL is silently best-effort: if err := c.Get(...); err == nil && status.URL != "". If the status fetch fails (e.g. 500, auth error, transient network issue), the error is dropped and the user sees the "Deployed …" line with no URL and no indication anything failed.

Suggested fix: surface the status-fetch failure (e.g. log/warn or append the error to the output) rather than swallowing it entirely.

Ref: PR #568

In `runPromote` (`internal/tpagectl/deployment/promote.go`), the site-status GET used to fetch the URL is silently best-effort: `if err := c.Get(...); err == nil && status.URL != ""`. If the status fetch fails (e.g. 500, auth error, transient network issue), the error is dropped and the user sees the "Deployed …" line with no URL and no indication anything failed. Suggested fix: surface the status-fetch failure (e.g. log/warn or append the error to the output) rather than swallowing it entirely. Ref: PR #568

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-08-06 05:43:44 +00:00

fuzzy referenced this issue from a commit

2026-08-11 01:29:27 +00:00

fix(tpagectl): address CLI issues

automation referenced this issue

2026-08-11 01:29:32 +00:00

fix(tpagectl): address CLI issues #634

automation closed this issue

2026-08-11 01:29:40 +00:00

automation commented

2026-08-11 01:29:41 +00:00

Owner

Fixed in #634: deployment promote prints a warning when the site-URL fetch fails instead of silently swallowing the error, and still reports deployment success.

Fixed in #634: `deployment promote` prints a warning when the site-URL fetch fails instead of silently swallowing the error, and still reports deployment success.

fuzzy referenced this issue from a commit

2026-08-11 01:29:56 +00:00

fix(tpagectl): address CLI issues