tpagectl: offline commands fail when server config is invalid #582

New issue

Closed

opened 2026-08-07 06:35:46 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-07 06:35:46 +00:00

Owner

tpagectl version runs the root command's Before hook, which loads the config and constructs the HTTP client (newClient in cmd/tpagectl/main.go). The version command never talks to the daemon, yet a misconfigured or invalid --server URL (or broken config file) would make version fail before its action runs.

Suggested fix: skip client construction for commands that don't need it (e.g. make version, --help, and completion bypass the client in the Before hook), or defer client construction to the commands that require it.

Ref: PR #581

`tpagectl version` runs the root command's `Before` hook, which loads the config and constructs the HTTP client (`newClient` in `cmd/tpagectl/main.go`). The `version` command never talks to the daemon, yet a misconfigured or invalid `--server` URL (or broken config file) would make `version` fail before its action runs. Suggested fix: skip client construction for commands that don't need it (e.g. make `version`, `--help`, and `completion` bypass the client in the Before hook), or defer client construction to the commands that require it. Ref: PR #581

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-08-07 06:35:53 +00:00

fuzzy referenced this issue from a commit

2026-08-11 01:29:27 +00:00

fix(tpagectl): address CLI issues

automation referenced this issue

2026-08-11 01:29:32 +00:00

fix(tpagectl): address CLI issues #634

automation closed this issue

2026-08-11 01:29:41 +00:00

automation commented

2026-08-11 01:29:43 +00:00

Owner

Fixed in #634: offline commands (version, help, completion, docs, any --examples) skip config/client bootstrap via offlineCommand, so they succeed even with a broken config or unusable --server.

Fixed in #634: offline commands (`version`, `help`, `completion`, `docs`, any `--examples`) skip config/client bootstrap via `offlineCommand`, so they succeed even with a broken config or unusable `--server`.

fuzzy referenced this issue from a commit

2026-08-11 01:29:56 +00:00

fix(tpagectl): address CLI issues