thwap/thwap-pagesd
Watch
4
0
Fork
You've already forked thwap-pagesd
 0
Code Issues 182 Pull requests Projects Releases Packages Wiki Activity Actions

tpagectl: login OIDC discovery has no timeout #587

New issue
Closed
opened 2026-08-07 14:35:07 +00:00 by the.auditor · 1 comment
the.auditor commented 2026-08-07 14:35:07 +00:00
Owner
Copy link

discoverEndpoints in internal/tpagectl/auth/login.go performs the OIDC discovery GET with http.DefaultClient, which has no timeout. Against a blackholed or unresponsive issuer, tpagectl login would hang indefinitely — the --timeout flag only bounds the DeviceAccessToken polling, not discovery or DeviceAuth.

Suggested fix: bound the discovery request (e.g. a client with a timeout, or reuse the --timeout deadline on the context).

Ref: PR #585

`discoverEndpoints` in `internal/tpagectl/auth/login.go` performs the OIDC discovery GET with `http.DefaultClient`, which has no timeout. Against a blackholed or unresponsive issuer, `tpagectl login` would hang indefinitely — the `--timeout` flag only bounds the `DeviceAccessToken` polling, not discovery or `DeviceAuth`. Suggested fix: bound the discovery request (e.g. a client with a timeout, or reuse the `--timeout` deadline on the context). Ref: PR #585
automation commented 2026-08-11 01:29:43 +00:00
Owner
Copy link

Fixed in #634: OIDC discovery uses a dedicated http.Client with a 30s timeout instead of the unbounded http.DefaultClient.

Fixed in #634: OIDC discovery uses a dedicated `http.Client` with a 30s timeout instead of the unbounded `http.DefaultClient`.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.5.2
v0.5.1
v0.5.0
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/thwap-pagesd#587
No description provided.