token set: positional arg leaks token in process list and shell history #592
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/thwap-pagesd#592
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
tpagectl token set <TOKEN>takes the token as a positional argument, exposing it viaps//procand shell history. For a credential-management feature, consider reading from stdin (token set -or--stdin) or an env var, and document the leak for the positional form.See #588
Resolved by design:
tpagectl token setreads the token from stdin when the positional argument is omitted, and the command help/description explicitly documents reading from stdin "to avoid leaking it via the shell history or process list". The positional form remains as a convenience with the leak documented. Closing; removing the positional form would be a breaking change and is tracked separately if desired.