credentials package and resolveToken lack unit tests #593

New issue

Closed

opened 2026-08-07 18:36:27 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-07 18:36:27 +00:00

Owner

internal/tpagectl/credentials has no tests; the keychain store is only exercised indirectly via fakeStore in the auth/token test packages. resolveToken in cmd/tpagectl/main.go also has no direct coverage (main_test only checks help output).

Consider testing the store against a keyring backend that works headless (e.g. keyring's file/memory backend) and table-driven tests for resolveToken precedence (config wins, keychain fallback, error paths).

See #588

`internal/tpagectl/credentials` has no tests; the keychain store is only exercised indirectly via `fakeStore` in the auth/token test packages. `resolveToken` in `cmd/tpagectl/main.go` also has no direct coverage (main_test only checks help output). Consider testing the store against a keyring backend that works headless (e.g. keyring's `file`/memory backend) and table-driven tests for `resolveToken` precedence (config wins, keychain fallback, error paths). See https://git.lan.thwap.org/thwap/thwap-pagesd/pulls/588

the.auditor added the

Kind/Testing

Priority

Low

labels

2026-08-07 18:36:36 +00:00

automation referenced this issue

2026-08-07 19:36:09 +00:00

feat(tpagectl): implement credential management #588

fuzzy referenced this issue from a commit

2026-08-11 12:32:47 +00:00

test(tpagectl): close tests-lump audit gaps

automation referenced this issue

2026-08-11 12:32:52 +00:00

test(tpagectl): close tests-lump audit gaps #635

fuzzy referenced this issue from a commit

2026-08-11 12:36:02 +00:00

test(tpagectl): close tests-lump audit gaps

automation closed this issue

2026-08-11 12:36:15 +00:00

automation commented

2026-08-11 12:36:15 +00:00

Owner

Fixed in #635: table-driven TestResolveToken covers config-wins, keychain fallback, empty, ErrUnavailable, ErrNotFound, and genuine-error propagation. The credentials package already had unit tests (credentials_test.go: opener sentinels, Set/Get/Delete, genuine-failure propagation) from the #588 pass.

Fixed in #635: table-driven `TestResolveToken` covers config-wins, keychain fallback, empty, `ErrUnavailable`, `ErrNotFound`, and genuine-error propagation. The `credentials` package already had unit tests (`credentials_test.go`: opener sentinels, Set/Get/Delete, genuine-failure propagation) from the #588 pass.