client.WithTLSConfig replaces transport, losing proxy support and default timeouts #598

New issue

Closed

opened 2026-08-08 05:09:27 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-08 05:09:27 +00:00

Owner

WithTLSConfig in internal/tpagectl/client/client.go sets c.hc.Transport = &http.Transport{TLSClientConfig: tlsConfig}, replacing the default transport entirely. This drops http.DefaultTransport behavior:

ProxyFromEnvironment is lost, so HTTP_PROXY/HTTPS_PROXY/NO_PROXY are ignored whenever --insecure or --ca-cert is set — a regression for users behind an HTTP proxy.
Default dial/TLS-handshake/idle-connection timeouts are lost.
HTTP/2 is not enabled (ForceAttemptHTTP2 unset).

Clone the default transport instead:

tr := http.DefaultTransport.(*http.Transport).Clone()
tr.TLSClientConfig = tlsConfig
c.hc.Transport = tr

See #597

`WithTLSConfig` in `internal/tpagectl/client/client.go` sets `c.hc.Transport = &http.Transport{TLSClientConfig: tlsConfig}`, replacing the default transport entirely. This drops `http.DefaultTransport` behavior: - `ProxyFromEnvironment` is lost, so `HTTP_PROXY`/`HTTPS_PROXY`/`NO_PROXY` are ignored whenever `--insecure` or `--ca-cert` is set — a regression for users behind an HTTP proxy. - Default dial/TLS-handshake/idle-connection timeouts are lost. - HTTP/2 is not enabled (`ForceAttemptHTTP2` unset). Clone the default transport instead: tr := http.DefaultTransport.(*http.Transport).Clone() tr.TLSClientConfig = tlsConfig c.hc.Transport = tr See https://git.lan.thwap.org/thwap/thwap-pagesd/pulls/597

the.auditor added the

Kind/Enhancement

Priority

Medium

labels

2026-08-08 05:09:31 +00:00

fuzzy referenced this issue from a commit

2026-08-11 01:29:27 +00:00

fix(tpagectl): address CLI issues

automation referenced this issue

2026-08-11 01:29:32 +00:00

fix(tpagectl): address CLI issues #634

automation closed this issue

2026-08-11 01:29:45 +00:00

automation commented

2026-08-11 01:29:46 +00:00

Owner

Fixed in #634: WithTLSConfig clones http.DefaultTransport before setting TLSClientConfig, preserving proxy and timeout behavior (test asserts Proxy is retained).

Fixed in #634: `WithTLSConfig` clones `http.DefaultTransport` before setting `TLSClientConfig`, preserving proxy and timeout behavior (test asserts `Proxy` is retained).

fuzzy referenced this issue from a commit

2026-08-11 01:29:56 +00:00

fix(tpagectl): address CLI issues