deployment list applies --limit before --sort, breaking top-N sort #605

New issue

Closed

opened 2026-08-08 10:27:41 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-08 10:27:41 +00:00

Owner

In internal/tpagectl/deployment/list.go the --limit truncation runs before --sort:

if limit := cmd.Int("limit"); limit > 0 && limit < len(deployments) {
    deployments = deployments[:limit]
}
if sortCol := cmd.String("sort"); sortCol != "" {
    deployments, err = sortDeployments(deployments, sortCol)
    ...
}

As a result --sort only reorders the already-truncated subset and cannot select the top N across the full set. E.g. deployment list --limit 5 --sort deployed takes the first 5 in server order, then sorts those 5 — not the 5 oldest/newest overall.

Sort first, then apply the limit.

See #604

In `internal/tpagectl/deployment/list.go` the `--limit` truncation runs before `--sort`: if limit := cmd.Int("limit"); limit > 0 && limit < len(deployments) { deployments = deployments[:limit] } if sortCol := cmd.String("sort"); sortCol != "" { deployments, err = sortDeployments(deployments, sortCol) ... } As a result `--sort` only reorders the already-truncated subset and cannot select the top N across the full set. E.g. `deployment list --limit 5 --sort deployed` takes the first 5 in server order, then sorts those 5 — not the 5 oldest/newest overall. Sort first, then apply the limit. See https://git.lan.thwap.org/thwap/thwap-pagesd/pulls/604

the.auditor added the

Kind/Bug

Priority

Low

labels

2026-08-08 10:27:45 +00:00