--examples is not fully offline: root Before hook still bootstraps the client #611

New issue

Closed

opened 2026-08-08 15:14:33 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-08 15:14:33 +00:00

Owner

examples.Apply short-circuits --examples inside the command's Action, but the root command's Before hook (config load, newClient → keychain token resolve, TLS config) runs first. So tpagectl site create --examples still requires a successful bootstrap: a malformed config, a genuine keychain error (propagated by resolveToken), or a broken --ca-cert path makes --examples fail instead of printing — contradicting the "works offline" claim.

Short-circuit earlier (e.g. skip client construction in the root Before when --examples is set, or handle --examples in a command-level Before).

See #610

`examples.Apply` short-circuits `--examples` inside the command's Action, but the root command's `Before` hook (config load, `newClient` → keychain token resolve, TLS config) runs first. So `tpagectl site create --examples` still requires a successful bootstrap: a malformed config, a genuine keychain error (propagated by `resolveToken`), or a broken `--ca-cert` path makes `--examples` fail instead of printing — contradicting the "works offline" claim. Short-circuit earlier (e.g. skip client construction in the root `Before` when `--examples` is set, or handle `--examples` in a command-level `Before`). See https://git.lan.thwap.org/thwap/thwap-pagesd/pulls/610

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-08-08 15:14:38 +00:00

fuzzy referenced this issue from a commit

2026-08-11 01:29:27 +00:00

fix(tpagectl): address CLI issues

automation referenced this issue

2026-08-11 01:29:32 +00:00

fix(tpagectl): address CLI issues #634

automation closed this issue

2026-08-11 01:29:48 +00:00

automation commented

2026-08-11 01:29:49 +00:00

Owner

Fixed in #634: --examples output is generated without config/client bootstrap (covered by the new offlineCommand), so it works with a broken config or no server.

Fixed in #634: `--examples` output is generated without config/client bootstrap (covered by the new `offlineCommand`), so it works with a broken config or no server.

fuzzy referenced this issue from a commit

2026-08-11 01:29:56 +00:00

fix(tpagectl): address CLI issues