watch --once exits 0 even when the poll failed #625

New issue

Closed

opened 2026-08-09 23:48:07 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-08-09 23:48:07 +00:00

Owner

In internal/tpagectl/watch/watch.go, a non-404 poll failure prints watch: <err> and then falls through to the if cmd.Bool("once") { return nil } check, so tpagectl watch SITE --once exits 0 even when the check failed (5xx, network error). Since --once is documented for scripting/CI, a failed check should exit non-zero.

Return the last poll error (or the error directly) for --once so scripts can detect failure.

See #624

In `internal/tpagectl/watch/watch.go`, a non-404 poll failure prints `watch: <err>` and then falls through to the `if cmd.Bool("once") { return nil }` check, so `tpagectl watch SITE --once` exits 0 even when the check failed (5xx, network error). Since `--once` is documented for scripting/CI, a failed check should exit non-zero. Return the last poll error (or the error directly) for `--once` so scripts can detect failure. See https://git.lan.thwap.org/thwap/thwap-pagesd/pulls/624

the.auditor added the

Kind/Bug

Priority

Medium

labels

2026-08-09 23:48:10 +00:00