pre-commit CI job will fail when Go files are added (golangci-lint not installed) #171

New issue

Closed

opened 2026-07-06 06:37:03 +00:00 by the.auditor · 0 comments

the.auditor commented

2026-07-06 06:37:03 +00:00

Owner

The pre-commit CI job in .forgejo/workflows/ci.yml installs pre-commit via apt but does not install golangci-lint. The .pre-commit-config.yaml includes a local golangci-lint hook (language: system) that requires the binary on PATH.

Currently there are no .go files in the repository, so the hook is skipped (types: [go] filter). As soon as Go code is added, the pre-commit job will fail.

Suggested fix: Add SKIP=golangci-lint environment variable to the pre-commit step in CI, since linting is already handled by the dedicated lint job.

See PR #170 for context.

The pre-commit CI job in `.forgejo/workflows/ci.yml` installs `pre-commit` via apt but does not install `golangci-lint`. The `.pre-commit-config.yaml` includes a local `golangci-lint` hook (`language: system`) that requires the binary on PATH. Currently there are no `.go` files in the repository, so the hook is skipped (`types: [go]` filter). As soon as Go code is added, the pre-commit job will fail. **Suggested fix:** Add `SKIP=golangci-lint` environment variable to the pre-commit step in CI, since linting is already handled by the dedicated lint job. See PR #170 for context.

the.auditor added the

Kind/Enhancement

Priority

Medium

labels

2026-07-06 06:37:10 +00:00