- Go 95.2%
- Assembly 4.4%
- C 0.2%
| Filename | Latest commit message | Latest commit date |
|---|---|---|
38d1265e1a
When "go test" is applied to multiple packages, it runs cmd/vet
without -json (in contrast to "go vet"). If a package has diagnostics,
the vet tool prints them to stderr and exits nonzero.
Vet actions in the build graph set IgnoreFail so that upstream
diagnostics do not suppress vetting and testing of downstream
packages. However, when sh.run returns an error, Builder.vet returns
immediately without recording a.built.
Previously this was benign because unitchecker imported types from the
compiler's export data (cfg.PackageFile), treating missing .vetx
entries in cfg.PackageVetx as merely lacking analyzer facts. However,
with unitchecker transitioning to doing its own type export through
.vetx files, a missing .vetx file causes downstream typechecking to
fail entirely ("no package vetx file for ..."), causing downstream
test runs to fail with "[build failed]".
This change ensures that if the vet tool exited non-zero but nonetheless
successfully produced its output file (vcfg.VetxOutput), a.built is still
recorded in memory so that downstream actions in the same build graph
can locate the dependency's types and facts.
To preserve cache integrity:
- The .vetx file is only written to the persistent cache (cache.Default)
when runErr == nil.
- runErr is still returned, ensuring that the failing package is still
reported as a failure and its own test binary is not run.
Updates #81188
Change-Id: I26d36c0d1874dc1f78162cc84b6eeebe513b643d
Reviewed-on: https://go-review.googlesource.com/c/go/+/827884
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
|
||
| .github | ||
| api | ||
| doc | ||
| lib | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.