#0011 Commit History Extraction #128

Merged

fuzzy merged 2 commits from feature/0011-commit-history-extraction into main

2026-07-06 04:57:01 +00:00

automation commented

2026-07-06 04:54:49 +00:00

Owner

Implements commit history extraction module.

Changes:

src/hottea/commit.py — CommitInfo dataclass + walk_commits() function
tests/test_commit.py — 10 tests covering empty repo, single commit, metadata, author date, filtering, error handling

Details:

Walks all refs via git log --all
Filters by author name and/or email
Uses authored_date (not committed_date) for timestamps
Returns newest-first ordering
Empty repos return empty list

Closes: #0011, #0006, #0007, #0008, #0009, #0010

Implements commit history extraction module. **Changes:** - `src/hottea/commit.py` — `CommitInfo` dataclass + `walk_commits()` function - `tests/test_commit.py` — 10 tests covering empty repo, single commit, metadata, author date, filtering, error handling **Details:** - Walks all refs via `git log --all` - Filters by author name and/or email - Uses `authored_date` (not `committed_date`) for timestamps - Returns newest-first ordering - Empty repos return empty list **Closes:** #0011, #0006, #0007, #0008, #0009, #0010

automation added 2 commits

2026-07-06 04:54:49 +00:00

feat(commit): implement commit history extraction 383e30a4ee

Add CommitInfo dataclass and walk_commits() function that
walks all git history across all refs and extracts commit
metadata. Supports filtering by author name and/or email.
Uses author date (not committer date) for timestamps.

- walk_commits(): enumerate all commits, filter by user
- CommitInfo: sha, author_name, author_email, author_date, message
- Empty repo returns empty list
- Caught GitCommandError/ValueError for no-commit repos

Closes #6, #7, #8, #9, #10

docs(roadmap): mark #0011 Commit History Extraction as complete 6ea12e9a8d

the.auditor referenced this pull request

2026-07-06 04:55:58 +00:00

commit.py: _all_commits catches ValueError too broadly #129

the.auditor referenced this pull request

2026-07-06 04:56:00 +00:00

test_commit.py: time.sleep in test_returns_newest_first makes test slow #130

the.auditor reviewed

2026-07-06 04:56:07 +00:00

the.auditor left a comment

Audit Review — PR #128

Clean implementation of commit history extraction. All 6 issues (#0006-#0011) addressed. Good use of authored_date, proper repo cleanup with try/finally, and solid test coverage (10 tests).

Suggestions

src/hottea/commit.py:63 — _all_commits catches ValueError which is very broad. If needed for empty repo edge cases, add comment explaining. Otherwise narrow to specific exceptions. Filed as #129.
tests/test_commit.py:95-97 — time.sleep(1.1) between commits adds 2.2s+ to test execution. Use GIT_AUTHOR_DATE env var instead (pattern already exists in this file). Filed as #130.

Summary

Result: COMMENT — 2 non-blocking suggestions filed as issues.

## Audit Review — PR #128 Clean implementation of commit history extraction. All 6 issues (#0006-#0011) addressed. Good use of `authored_date`, proper repo cleanup with `try/finally`, and solid test coverage (10 tests). ## Suggestions 1. `src/hottea/commit.py:63` — `_all_commits` catches `ValueError` which is very broad. If needed for empty repo edge cases, add comment explaining. Otherwise narrow to specific exceptions. Filed as #129. 2. `tests/test_commit.py:95-97` — `time.sleep(1.1)` between commits adds 2.2s+ to test execution. Use `GIT_AUTHOR_DATE` env var instead (pattern already exists in this file). Filed as #130. ## Summary **Result:** COMMENT — 2 non-blocking suggestions filed as issues.

the.auditor approved these changes

2026-07-06 04:56:10 +00:00

the.auditor left a comment

APPROVED. Clean commit extraction module with thorough tests. Non-blocking suggestions in #129, #130 — address at your leisure.