#0047 SQL Output Options #140
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/hottea!140
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/0047-sql-output-options"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Implements CLI entry point and SQL output options.
Changes:
src/hottea/cli.py— full CLI tool with--end-date,--outputflagssrc/hottea/sql.py—generate_sql()now accepts per-recordcommentssequencetests/test_cli.py— 6 parser teststests/test_sql.py— 1 new per-record comments testPipeline:
Output features:
--output FILEto write to fileBEGIN TRANSACTION/COMMITwrapperCloses: #0047, #0042, #0043, #0044, #0045, #0046
Audit Review — PR #140
Solid CLI implementation with full pipeline: config → git user → walk commits → Forgejo lookup → build records → generate SQL. Good use of argparse, clean per-record comments refactor in
generate_sql().Suggestions
src/hottea/cli.py—main()has no exception handling. If config is missing, git repo is invalid, or Forgejo API is down, the user gets a raw traceback. Should catch known exceptions (ConfigError,GitRepoError,ForgejoErroretc.) and print clean error messages. Filed as #141.Summary
Result: COMMENT — 1 non-blocking suggestion filed as issue.
APPROVED. Full pipeline works end-to-end, clean CLI structure. Non-blocking suggestion in #141 (error handling polish) — address at your leisure.