#0111 Database Abstraction #157
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/hottea!157
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/0111-database-abstraction"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Completes database abstraction with MySQL and PostgreSQL support.
Changes:
src/hottea/sql.py—PostgreSQLGenerator,get_generator()factorysrc/hottea/cli.py—--dbflag for selecting database backendtests/test_sql.py— 8 new tests for PostgreSQL, get_generatortests/test_cli.py— 3 new tests for --db flagUsage:
Supported backends:
sqlite3—BEGIN TRANSACTION/COMMIT(default)mysql—START TRANSACTION/COMMITpostgresql—BEGIN/COMMITCloses: #0111, #0107, #0108, #0109, #0110
Audit Review — PR #157
Clean database abstraction completion. All 4 issues (#0107-#0110) addressed. PostgreSQLGenerator added, get_generator() factory with registry, --db CLI flag with choices validation. Tests cover all backends and unknown backend error.
No suggestions — clean PR.
Summary
Result: COMMENT — no issues found.
APPROVED. Database abstraction complete with all three backends. Merge when ready.