thwap/hottea
Watch
4
0
Fork
You've already forked hottea
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: consolidate identical non_git_dir and empty_dir fixtures #163

Merged
fuzzy merged 1 commit from fix/127-conftest-identical-fixtures into main 2026-07-06 08:29:39 +00:00
Conversation 2 Commits 1 Files changed 1 +8 -4
automation commented 2026-07-06 08:25:54 +00:00
Owner
Copy link

Consolidates the two identical non_git_dir and empty_dir fixtures in tests/conftest.py. empty_dir now delegates to non_git_dir via pytest fixture injection. Both kept as separate fixtures with docstrings clarifying they may diverge in future.

Closes #127

Consolidates the two identical `non_git_dir` and `empty_dir` fixtures in `tests/conftest.py`. `empty_dir` now delegates to `non_git_dir` via pytest fixture injection. Both kept as separate fixtures with docstrings clarifying they may diverge in future. Closes #127
fix(tests): consolidate identical non_git_dir and empty_dir fixtures
All checks were successful
CI / lint-and-test (pull_request) Successful in 1m32s
Details
41624261b3 
empty_dir now delegates to non_git_dir via pytest fixture
injection. Both kept as separate fixtures with docstrings
clarifying they may diverge in future.

Closes #127
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-06 08:26:00 +00:00
the.auditor reviewed 2026-07-06 08:26:18 +00:00
the.auditor left a comment
Copy link

Audit Review — PR #163

Clean fix for #127. empty_dir now delegates to non_git_dir via pytest fixture injection. Docstrings clarify future intent. No functional change, just DRY.

No suggestions.

Summary

Result: COMMENT — no issues found.

## Audit Review — PR #163 Clean fix for #127. `empty_dir` now delegates to `non_git_dir` via pytest fixture injection. Docstrings clarify future intent. No functional change, just DRY. No suggestions. ## Summary **Result:** COMMENT — no issues found.
the.auditor approved these changes 2026-07-06 08:26:22 +00:00
the.auditor left a comment
Copy link

APPROVED. Fixtures consolidated, closes #127. Merge when ready.

APPROVED. Fixtures consolidated, closes #127. Merge when ready.
fuzzy merged commit 41624261b3 into main 2026-07-06 08:29:39 +00:00
fuzzy deleted branch fix/127-conftest-identical-fixtures 2026-07-06 08:29:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/hottea!163
No description provided.