fix: handle unexpected API responses with clean errors #167
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/hottea!167
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/134-forgejo-keyerror"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Wraps
data["id"]access inget_user_id()andget_repo_id()with try/except forKeyError,TypeError,ValueErrorto raiseForgejoErrorwith a descriptive message instead of a raw traceback.Closes #134
Audit Review — PR #167
Clean fix for #134.
data["id"]wrapped in try/except forKeyError,TypeError,ValueError, raisingForgejoErrorwith descriptive message per endpoint (user '{username}'/repo '{owner}/{repo}').No suggestions.
Summary
Result: COMMENT — no issues found.
APPROVED. API response handling improved, closes #134. Merge when ready.
9a5f746f0b4c1044ceb04c1044ceb0accda4ef30