fix: make git path resolution lazy instead of import-time #161
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/hottea!161
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/125-git-import-side-effect"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Moves
shutil.which("git")from module-level import into a lazy_resolve_git()function. The module can now be imported in environments without git;GitNotFoundErroronly raises when a git function is actually called.Closes #125
Move shutil.which('git') from module level into lazy _resolve_git() function. The module can now be imported safely in environments without git; GitNotFoundError only raises when a git function is actually called. Closes #125Audit Review — PR #161
Clean fix for #125. Module-level
shutil.which("git")moved to lazy_resolve_git()with caching._GIT_PATHinitialized toNone, resolved on first_run_git()call. No more import-time side effects.No suggestions.
Summary
Result: COMMENT — no issues found.
APPROVED. Clean lazy resolution, closes #125. Merge when ready.