thwap/hottea
Watch
4
0
Fork
You've already forked hottea
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: narrow _all_commits exception handling #164

Merged
fuzzy merged 1 commit from fix/129-commit-valueerror-broad into main 2026-07-06 08:33:51 +00:00
Conversation 2 Commits 1 Files changed 1 +3 -1
automation commented 2026-07-06 08:26:51 +00:00
Owner
Copy link

Replaces broad ValueError catch with early repo.heads check. Empty repos return empty list immediately without calling iter_commits(), which avoids the need for the broad exception handler.

Closes #129

Replaces broad `ValueError` catch with early `repo.heads` check. Empty repos return empty list immediately without calling `iter_commits()`, which avoids the need for the broad exception handler. Closes #129
fix(commit): narrow _all_commits exception handling
Some checks failed
CI / lint-and-test (pull_request) Has been cancelled
Details
08ad63acd7 
Check repo.heads early to avoid calling iter_commits on
empty repos. Removes the broad ValueError catch.

Closes #129
fuzzy force-pushed fix/129-commit-valueerror-broad from 08ad63acd7
Some checks failed
CI / lint-and-test (pull_request) Has been cancelled
Details
to e0da2a8924
All checks were successful
CI / lint-and-test (pull_request) Successful in 1m35s
Details
2026-07-06 08:30:36 +00:00 Compare
the.auditor reviewed 2026-07-06 08:31:01 +00:00
the.auditor left a comment
Copy link

Audit Review — PR #164

Clean fix for #129. repo.heads check returns early for empty repos, removing need for ValueError catch. Exception handling now narrowed to GitCommandError only.

No suggestions.

Summary

Result: COMMENT — no issues found.

## Audit Review — PR #164 Clean fix for #129. `repo.heads` check returns early for empty repos, removing need for `ValueError` catch. Exception handling now narrowed to `GitCommandError` only. No suggestions. ## Summary **Result:** COMMENT — no issues found.
the.auditor approved these changes 2026-07-06 08:31:05 +00:00
the.auditor left a comment
Copy link

APPROVED. Exception handling narrowed, closes #129. Merge when ready.

APPROVED. Exception handling narrowed, closes #129. Merge when ready.
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-06 08:32:19 +00:00
fuzzy merged commit e0da2a8924 into main 2026-07-06 08:33:51 +00:00
fuzzy deleted branch fix/129-commit-valueerror-broad 2026-07-06 08:33:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/hottea!164
No description provided.