fix: narrow broad Exception catch in validate_environment #171
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/hottea!171
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/147-validate-broad-exception"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Replaces broad
except Exceptionwithexcept (InvalidRepoError, GitNotFoundError)when validating repository paths invalidate_environment().Closes #147
Audit Review — PR #171
Clean fix for #147.
except Exceptionnarrowed to(InvalidRepoError, GitNotFoundError)invalidate_environment(). Proper imports fromhottea.exceptions.No suggestions.
Summary
Result: COMMENT — no issues found.
APPROVED. Exception handling tightened, closes #147. Merge when ready.