thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(notifications): add webhook and email notification support #118

Merged
fuzzy merged 2 commits from feature/0071-add-webhook-notification-support into main 2026-07-05 15:53:22 +00:00
Conversation 1 Commits 2 Files changed 7 +431 -40
automation commented 2026-07-05 15:50:42 +00:00
Owner
Copy link

What

Add webhook and email notification support for job completion events. Webhooks POST JSON payloads to a configurable URL. Email alerts send via SMTP with TLS and optional auth.

Why

Users need to be notified when jobs complete or fail, either via webhook integration or email.

Testing

  • 145 unit tests pass (11 new for notifications)
  • Pre-commit hooks pass (ruff + mypy strict)
  • Coverage: 90%

Breaking Changes

None.

Notes

Notification config in [notifications] section with webhook_url, smtp_* fields, and on_failure_only flag.

Closes #0069
Closes #0070
Closes #0071

## What Add webhook and email notification support for job completion events. Webhooks POST JSON payloads to a configurable URL. Email alerts send via SMTP with TLS and optional auth. ## Why Users need to be notified when jobs complete or fail, either via webhook integration or email. ## Testing - [x] 145 unit tests pass (11 new for notifications) - [x] Pre-commit hooks pass (ruff + mypy strict) - [x] Coverage: 90% ## Breaking Changes None. ## Notes Notification config in `[notifications]` section with `webhook_url`, `smtp_*` fields, and `on_failure_only` flag. Closes #0069 Closes #0070 Closes #0071
- Webhook POST with JSON payload on job completion
- Email alerts via SMTP (TLS, auth, configurable recipients)
- on_failure_only flag to skip success notifications
- Integrated into job lifecycle in run_job
- NotificationConfig model and config merge support
Closes #0069
Closes #0070
Closes #0071
docs: mark Phase 5 Task 2 complete
All checks were successful
CI / test (pull_request) Successful in 55s
Details
CI / lint (pull_request) Successful in 1m24s
Details
66a977ba5f 
Webhook and email notification support done.
Closes #0071
the.auditor approved these changes 2026-07-05 15:52:44 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #118

Result: APPROVED

The final PR on the ROADMAP. Webhook and email notification support rounds out the feature set. Clean implementation.

  • Correctness: send_webhook POSTs JSON, checks HTTP 400+. send_email supports STARTTLS + optional auth. notify() dispatches both channels independently, respects on_failure_only, and logs errors without blocking job execution. _build_payload creates structured event data.
  • Completeness: Closes #69–#71. ROADMAP fully complete. NotificationConfig dataclass added, config merging handles nested dataclass, engine wired up on MCP error / LLM error / success paths.
  • Test coverage: 11 tests covering payload building, webhook (POST, HTTP error), email (TLS+auth, no auth, connection error), and notify dispatch (skip on success, webhook sent, email on failure, webhook error logged).
  • Error handling: All notification errors caught and logged as warnings — non-blocking by design.
  • Maintainability: Clean 159-line module. send_webhook / send_email separated from dispatch logic. Engine test refactored with _mock_config() helper (nice dedup).

Suggestions (non-blocking)

  1. src/kronai/notifications.py:100-108 — send_email only supports STARTTLS (port 587). No implicit TLS (SMTP_SSL, port 465). Consider adding smtp_use_ssl config flag that uses smtplib.SMTP_SSL instead.

  2. src/kronai/notifications.py:69-76 — send_webhook has no retry logic. Unlike the LLM client (which has exponential backoff), transient webhook failures are silently logged. Consider adding retry with backoff for transient failures.

  3. src/kronai/engine.py:65 — Config is loaded inside run_job() but also in run_interval(). For an interval of N jobs, config is loaded N+1 times. Consider passing config from run_interval() to run_job() (building on the earlier refactor that moved config load earlier in this PR).

## Automated Review — PR #118 **Result: APPROVED** --- The final PR on the ROADMAP. Webhook and email notification support rounds out the feature set. Clean implementation. - **Correctness**: `send_webhook` POSTs JSON, checks HTTP 400+. `send_email` supports STARTTLS + optional auth. `notify()` dispatches both channels independently, respects `on_failure_only`, and logs errors without blocking job execution. `_build_payload` creates structured event data. - **Completeness**: Closes #69–#71. ROADMAP fully complete. `NotificationConfig` dataclass added, config merging handles nested dataclass, engine wired up on MCP error / LLM error / success paths. - **Test coverage**: 11 tests covering payload building, webhook (POST, HTTP error), email (TLS+auth, no auth, connection error), and notify dispatch (skip on success, webhook sent, email on failure, webhook error logged). - **Error handling**: All notification errors caught and logged as warnings — non-blocking by design. - **Maintainability**: Clean 159-line module. `send_webhook` / `send_email` separated from dispatch logic. Engine test refactored with `_mock_config()` helper (nice dedup). ### Suggestions (non-blocking) 1. **`src/kronai/notifications.py:100-108`** — `send_email` only supports STARTTLS (port 587). No implicit TLS (SMTP_SSL, port 465). Consider adding `smtp_use_ssl` config flag that uses `smtplib.SMTP_SSL` instead. 2. **`src/kronai/notifications.py:69-76`** — `send_webhook` has no retry logic. Unlike the LLM client (which has exponential backoff), transient webhook failures are silently logged. Consider adding retry with backoff for transient failures. 3. **`src/kronai/engine.py:65`** — Config is loaded inside `run_job()` but also in `run_interval()`. For an interval of N jobs, config is loaded N+1 times. Consider passing config from `run_interval()` to `run_job()` (building on the earlier refactor that moved config load earlier in this PR).
fuzzy merged commit 66a977ba5f into main 2026-07-05 15:53:22 +00:00
fuzzy deleted branch feature/0071-add-webhook-notification-support 2026-07-05 15:53:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!118
No description provided.