thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(config): support KRONAI_LLM_API_KEY env var as secure alternative #123

Merged
fuzzy merged 1 commit from fix/0075-env-var-api-key into main 2026-07-05 16:06:11 +00:00
Conversation 1 Commits 1 Files changed 2 +7
automation commented 2026-07-05 16:02:18 +00:00
Owner
Copy link

What

Add KRONAI_LLM_API_KEY environment variable support. When set, it overrides the llm_api_key from the config file, enabling deployment without secrets in files.

Why

Security best practice — API keys should not be stored in config files in production.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #75

## What Add `KRONAI_LLM_API_KEY` environment variable support. When set, it overrides the `llm_api_key` from the config file, enabling deployment without secrets in files. ## Why Security best practice — API keys should not be stored in config files in production. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #75
feat(config): support KRONAI_LLM_API_KEY env var as secure alternative
All checks were successful
CI / test (pull_request) Successful in 53s
Details
CI / lint (pull_request) Successful in 1m24s
Details
c223b87f38 
Env var overrides llm_api_key from config file, enabling deployment
without storing secrets in config files.
Closes #75
the.auditor approved these changes 2026-07-05 16:05:56 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #123

Result: APPROVED

Clean, minimal fix. KRONAI_LLM_API_KEY env var overrides the config file value when set. Example config updated with security note.

  • Correctness: Env var is merged via merge_config after file-based config, so it takes precedence. No secrets in config files needed in production.
  • Completeness: Closes #75.

No suggestions.

## Automated Review — PR #123 **Result: APPROVED** --- Clean, minimal fix. `KRONAI_LLM_API_KEY` env var overrides the config file value when set. Example config updated with security note. - **Correctness**: Env var is merged via `merge_config` after file-based config, so it takes precedence. No secrets in config files needed in production. - **Completeness**: Closes #75. No suggestions.
fuzzy merged commit c223b87f38 into main 2026-07-05 16:06:11 +00:00
fuzzy deleted branch fix/0075-env-var-api-key 2026-07-05 16:06:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!123
No description provided.