thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf(engine): pass config to run_job to avoid N+1 config loads #136

Merged
fuzzy merged 1 commit from fix/0094-config-loaded-n-plus-1 into main 2026-07-05 16:50:55 +00:00
Conversation 1 Commits 1 Files changed 1 +6 -4
automation commented 2026-07-05 16:46:41 +00:00
Owner
Copy link

What

Add optional config param to run_job(). When provided, config is not reloaded from disk. run_interval() now loads config once and passes it to each job.

Why

Eliminates N redundant load_config() calls when running N jobs in an interval.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #94

## What Add optional `config` param to `run_job()`. When provided, config is not reloaded from disk. `run_interval()` now loads config once and passes it to each job. ## Why Eliminates N redundant `load_config()` calls when running N jobs in an interval. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #94
perf(engine): pass config to run_job to avoid N+1 config loads
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
7aded86ef1 
run_interval now loads config once and passes it to each
run_job call, eliminating N redundant load_config() calls.
Closes #94
fuzzy force-pushed fix/0094-config-loaded-n-plus-1 from 7aded86ef1
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
to dcab40a20f
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
2026-07-05 16:47:05 +00:00 Compare
fuzzy force-pushed fix/0094-config-loaded-n-plus-1 from dcab40a20f
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
to 4e9ec21af3
All checks were successful
CI / test (pull_request) Successful in 52s
Details
CI / lint (pull_request) Successful in 1m17s
Details
2026-07-05 16:48:39 +00:00 Compare
the.auditor approved these changes 2026-07-05 16:50:40 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #136

Result: APPROVED

Clean perf fix — adds optional config param to run_job(). run_interval() now loads config once and passes it, eliminating N redundant load_config() calls. Backward-compatible (defaults to None, loads from disk). Closes #94.

No suggestions.

## Automated Review — PR #136 **Result: APPROVED** --- Clean perf fix — adds optional `config` param to `run_job()`. `run_interval()` now loads config once and passes it, eliminating N redundant `load_config()` calls. Backward-compatible (defaults to None, loads from disk). Closes #94. No suggestions.
fuzzy merged commit 4e9ec21af3 into main 2026-07-05 16:50:55 +00:00
fuzzy deleted branch fix/0094-config-loaded-n-plus-1 2026-07-05 16:50:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!136
No description provided.