thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf(discovery): reduce redundant filesystem scans in find_job #141

Merged
fuzzy merged 1 commit from fix/0100-find-job-optimize into main 2026-07-05 17:13:01 +00:00
Conversation 1 Commits 1 Files changed 1 +5 -3
automation commented 2026-07-05 16:58:14 +00:00
Owner
Copy link

What

Reuse scan_intervals() results instead of re-iterating jobs_dir for symlink lookup in find_job().

Why

Avoids redundant filesystem scans — discover_jobs() already discovers all jobs, and scan_intervals() provides the interval structure without a second pass.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #100

## What Reuse `scan_intervals()` results instead of re-iterating `jobs_dir` for symlink lookup in `find_job()`. ## Why Avoids redundant filesystem scans — `discover_jobs()` already discovers all jobs, and `scan_intervals()` provides the interval structure without a second pass. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #100
perf(discovery): reduce redundant filesystem scans in find_job
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
5a07b12569 
Reuse scan_intervals results instead of re-iterating jobs_dir
for symlink lookup.
Closes #100
fuzzy force-pushed fix/0100-find-job-optimize from 5a07b12569
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
to 12e1b60df0
Some checks failed
CI / lint (pull_request) Successful in 1m18s
Details
CI / test (pull_request) Has been cancelled
Details
2026-07-05 17:00:50 +00:00 Compare
fuzzy self-assigned this 2026-07-05 17:01:21 +00:00
fuzzy force-pushed fix/0100-find-job-optimize from 12e1b60df0
Some checks failed
CI / lint (pull_request) Successful in 1m18s
Details
CI / test (pull_request) Has been cancelled
Details
to 9112be6a8d
All checks were successful
CI / test (pull_request) Successful in 48s
Details
CI / lint (pull_request) Successful in 1m21s
Details
2026-07-05 17:05:15 +00:00 Compare
the.auditor approved these changes 2026-07-05 17:09:30 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #141

Result: APPROVED

Clean perf fix — reuses scan_intervals() results instead of manually re-iterating jobs_dir for symlink lookup. Also simplifies path comparison (removes redundant job.path == target check since job.path.resolve() covers it). Closes #100.

No suggestions.

## Automated Review — PR #141 **Result: APPROVED** --- Clean perf fix — reuses `scan_intervals()` results instead of manually re-iterating `jobs_dir` for symlink lookup. Also simplifies path comparison (removes redundant `job.path == target` check since `job.path.resolve()` covers it). Closes #100. No suggestions.
fuzzy merged commit 9112be6a8d into main 2026-07-05 17:13:01 +00:00
fuzzy deleted branch fix/0100-find-job-optimize 2026-07-05 17:13:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
fuzzy
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!141
No description provided.