thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(config): support KRONAI_CONFIG env var for config path #144

Merged
fuzzy merged 1 commit from fix/0104-kronai-config-env-var into main 2026-07-05 17:28:10 +00:00
Conversation 1 Commits 1 Files changed 2 +8 -3
automation commented 2026-07-05 17:05:21 +00:00
Owner
Copy link

What

Add KRONAI_CONFIG env var support to load_config(). Fix systemd docs to use --config flag instead of non-existent Environment=KRONAI_CONFIG.

Why

Env var provides a convenient way to point to a non-default config. Docs fix ensures the systemd example works correctly.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #104

## What Add `KRONAI_CONFIG` env var support to `load_config()`. Fix systemd docs to use `--config` flag instead of non-existent `Environment=KRONAI_CONFIG`. ## Why Env var provides a convenient way to point to a non-default config. Docs fix ensures the systemd example works correctly. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #104
feat(config): support KRONAI_CONFIG env var for config path
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
a09f97cbbc 
Also fix systemd example in docs to use --config flag instead
of non-existent KRONAI_CONFIG env var in Environment=.
Closes #104
fuzzy force-pushed fix/0104-kronai-config-env-var from a09f97cbbc
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
to 393496681d
All checks were successful
CI / lint (pull_request) Successful in 1m16s
Details
CI / test (pull_request) Successful in 52s
Details
2026-07-05 17:05:41 +00:00 Compare
the.auditor approved these changes 2026-07-05 17:10:40 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #144

Result: APPROVED

Two fixes in one: adds KRONAI_CONFIG env var support (read before _resolve_config_path, overridden by explicit path arg), and fixes systemd docs to use --config flag instead of non-functional Environment=KRONAI_CONFIG. Closes #104.

No suggestions.

## Automated Review — PR #144 **Result: APPROVED** Two fixes in one: adds `KRONAI_CONFIG` env var support (read before `_resolve_config_path`, overridden by explicit `path` arg), and fixes systemd docs to use `--config` flag instead of non-functional `Environment=KRONAI_CONFIG`. Closes #104. No suggestions.
fuzzy force-pushed fix/0104-kronai-config-env-var from 393496681d
All checks were successful
CI / lint (pull_request) Successful in 1m16s
Details
CI / test (pull_request) Successful in 52s
Details
to d99b4b6e6a
All checks were successful
CI / test (pull_request) Successful in 49s
Details
CI / lint (pull_request) Successful in 1m17s
Details
2026-07-05 17:13:38 +00:00 Compare
fuzzy force-pushed fix/0104-kronai-config-env-var from d99b4b6e6a
All checks were successful
CI / test (pull_request) Successful in 49s
Details
CI / lint (pull_request) Successful in 1m17s
Details
to c244004c3b
All checks were successful
CI / test (pull_request) Successful in 49s
Details
CI / lint (pull_request) Successful in 1m17s
Details
2026-07-05 17:20:18 +00:00 Compare
fuzzy force-pushed fix/0104-kronai-config-env-var from c244004c3b
All checks were successful
CI / test (pull_request) Successful in 49s
Details
CI / lint (pull_request) Successful in 1m17s
Details
to 6ae7d85a6c
All checks were successful
CI / test (pull_request) Successful in 50s
Details
CI / lint (pull_request) Successful in 1m19s
Details
2026-07-05 17:24:23 +00:00 Compare
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-05 17:26:45 +00:00
fuzzy merged commit 6ae7d85a6c into main 2026-07-05 17:28:10 +00:00
fuzzy deleted branch fix/0104-kronai-config-env-var 2026-07-05 17:28:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!144
No description provided.