thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf(cli): pass loaded config to subcommands to avoid double load #145

Merged
fuzzy merged 1 commit from fix/0106-pass-config-to-subcommands into main 2026-07-05 17:30:34 +00:00
Conversation 2 Commits 1 Files changed 1 +16 -8
automation commented 2026-07-05 17:06:45 +00:00
Owner
Copy link

What

_main() loads config once and passes it to _cmd_list, _cmd_run, and _cmd_interval instead of each subcommand loading it again.

Why

Eliminates redundant load_config() calls — config was being loaded twice for every CLI command.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #106

## What `_main()` loads config once and passes it to `_cmd_list`, `_cmd_run`, and `_cmd_interval` instead of each subcommand loading it again. ## Why Eliminates redundant `load_config()` calls — config was being loaded twice for every CLI command. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #106
perf(cli): pass loaded config to subcommands to avoid double load
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
7b82f40940 
_main() loads config once and passes it to _cmd_list, _cmd_run,
and _cmd_interval instead of each subcommand reloading it.
Closes #106
fuzzy force-pushed fix/0106-pass-config-to-subcommands from 7b82f40940
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
to 7b4891da45
All checks were successful
CI / test (pull_request) Successful in 49s
Details
CI / lint (pull_request) Successful in 1m18s
Details
2026-07-05 17:08:53 +00:00 Compare
the.auditor approved these changes 2026-07-05 17:10:41 +00:00
Dismissed
the.auditor left a comment
Copy link

Automated Review — PR #145

Result: APPROVED

Clean perf fix — _main() loads config once and passes it to _cmd_list, _cmd_run, and _cmd_interval via optional config param. Eliminates redundant load_config() per command. Closes #106.

No suggestions.

## Automated Review — PR #145 **Result: APPROVED** Clean perf fix — `_main()` loads config once and passes it to `_cmd_list`, `_cmd_run`, and `_cmd_interval` via optional `config` param. Eliminates redundant `load_config()` per command. Closes #106. No suggestions.
fuzzy force-pushed fix/0106-pass-config-to-subcommands from 7b4891da45
All checks were successful
CI / test (pull_request) Successful in 49s
Details
CI / lint (pull_request) Successful in 1m18s
Details
to 4a28a00ae4
All checks were successful
CI / test (pull_request) Successful in 48s
Details
CI / lint (pull_request) Successful in 1m19s
Details
2026-07-05 17:13:43 +00:00 Compare
fuzzy force-pushed fix/0106-pass-config-to-subcommands from 4a28a00ae4
All checks were successful
CI / test (pull_request) Successful in 48s
Details
CI / lint (pull_request) Successful in 1m19s
Details
to 3e82e9c3a8
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
2026-07-05 17:20:25 +00:00 Compare
fuzzy force-pushed fix/0106-pass-config-to-subcommands from 3e82e9c3a8
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
to e3121477c3
All checks were successful
CI / test (pull_request) Successful in 51s
Details
CI / lint (pull_request) Successful in 1m19s
Details
2026-07-05 17:24:28 +00:00 Compare
fuzzy dismissed the.auditor's review 2026-07-05 17:24:28 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-05 17:27:07 +00:00
the.auditor approved these changes 2026-07-05 17:27:25 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #145

Result: APPROVED

Clean perf fix — _main() loads config once and passes it to _cmd_list, _cmd_run, and _cmd_interval via optional config param. Eliminates redundant load_config() per command. Closes #106.

No suggestions.

## Automated Review — PR #145 **Result: APPROVED** --- Clean perf fix — `_main()` loads config once and passes it to `_cmd_list`, `_cmd_run`, and `_cmd_interval` via optional `config` param. Eliminates redundant `load_config()` per command. Closes #106. No suggestions.
fuzzy canceled auto merging this pull request when all checks succeed 2026-07-05 17:27:48 +00:00
fuzzy force-pushed fix/0106-pass-config-to-subcommands from e3121477c3
All checks were successful
CI / test (pull_request) Successful in 51s
Details
CI / lint (pull_request) Successful in 1m19s
Details
to 86613c55a4
All checks were successful
CI / lint (pull_request) Successful in 1m20s
Details
CI / test (pull_request) Successful in 49s
Details
2026-07-05 17:28:26 +00:00 Compare
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-05 17:30:05 +00:00
fuzzy self-assigned this 2026-07-05 17:30:19 +00:00
fuzzy merged commit 86613c55a4 into main 2026-07-05 17:30:34 +00:00
fuzzy deleted branch fix/0106-pass-config-to-subcommands 2026-07-05 17:30:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
fuzzy
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!145
No description provided.