test(log): isolate JSON format test with child logger #149

Merged

fuzzy merged 1 commit from fix/0108-fragile-log-test into main

2026-07-05 17:47:19 +00:00

automation commented

2026-07-05 17:44:41 +00:00

Owner

What

Use a non-propagating child logger with a dedicated StringIO handler instead of clearing root handler state.

Why

The previous approach of manually clearing root handlers was fragile — state could leak between tests.

Testing

145 unit tests pass
Pre-commit hooks pass

Closes #108

## What Use a non-propagating child logger with a dedicated `StringIO` handler instead of clearing root handler state. ## Why The previous approach of manually clearing root handlers was fragile — state could leak between tests. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #108

automation added 1 commit

2026-07-05 17:44:41 +00:00

test(log): isolate JSON format test with child logger

CI / test (pull_request) Has been cancelled

Details

CI / lint (pull_request) Has been cancelled

Details

ddbcebd5cf

Use a non-propagating child logger with dedicated handler instead
of clearing root handlers, preventing state leakage between tests.
Closes #108

the.auditor approved these changes

2026-07-05 17:45:41 +00:00

the.auditor left a comment

Automated Review — PR #149

Result: APPROVED

Clean fix — replaces fragile root handler manipulation with a non-propagating child logger and dedicated StringIO handler. Test is now fully isolated from other log test state. Closes #108.

No suggestions.

## Automated Review — PR #149 **Result: APPROVED** --- Clean fix — replaces fragile root handler manipulation with a non-propagating child logger and dedicated `StringIO` handler. Test is now fully isolated from other log test state. Closes #108. No suggestions.

fuzzy force-pushed fix/0108-fragile-log-test from ddbcebd5cf

CI / test (pull_request) Has been cancelled

Details

CI / lint (pull_request) Has been cancelled

Details

to ef32529a5a

CI / test (pull_request) Successful in 52s

Details

CI / lint (pull_request) Successful in 1m23s

Details

2026-07-05 17:45:51 +00:00

Compare