fix(engine): skip save_status for ephemeral jobs to avoid wasted writes #153

Merged
fuzzy merged 1 commit from fix/0117-ephemeral-status-lost into main 2026-07-05 17:59:53 +00:00
Owner

What

Only call save_status() for recurring (persistent) jobs. Ephemeral jobs skip the status write since their directory (including status.json) is deleted after execution.

Why

Previously, status was written to the job directory then immediately deleted — wasted I/O for no benefit.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #117

## What Only call `save_status()` for recurring (persistent) jobs. Ephemeral jobs skip the status write since their directory (including `status.json`) is deleted after execution. ## Why Previously, status was written to the job directory then immediately deleted — wasted I/O for no benefit. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #117
fix(engine): skip save_status for ephemeral jobs to avoid wasted writes
All checks were successful
CI / test (pull_request) Successful in 54s
CI / lint (pull_request) Successful in 1m20s
f2dec269e8
Ephemeral job status was written to status.json in the job
directory, then immediately deleted with shutil.rmtree. Now
save_status is only called for recurring jobs.
Closes #117
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-05 17:58:44 +00:00
the.auditor left a comment

Automated Review — PR #153

Result: APPROVED


Clean fix — moves save_status() and send_notifications() into if/else branches. Ephemeral jobs skip status write (wasted I/O since directory is deleted) but still send notifications. Recurring jobs get both. Closes #117.

No suggestions.

## Automated Review — PR #153 **Result: APPROVED** --- Clean fix — moves `save_status()` and `send_notifications()` into if/else branches. Ephemeral jobs skip status write (wasted I/O since directory is deleted) but still send notifications. Recurring jobs get both. Closes #117. No suggestions.
fuzzy merged commit f2dec269e8 into main 2026-07-05 17:59:53 +00:00
fuzzy deleted branch fix/0117-ephemeral-status-lost 2026-07-05 17:59:53 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!153
No description provided.