fix(engine): skip save_status for ephemeral jobs to avoid wasted writes #153
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/kronai!153
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/0117-ephemeral-status-lost"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Only call
save_status()for recurring (persistent) jobs. Ephemeral jobs skip the status write since their directory (includingstatus.json) is deleted after execution.Why
Previously, status was written to the job directory then immediately deleted — wasted I/O for no benefit.
Testing
Closes #117
Automated Review — PR #153
Result: APPROVED
Clean fix — moves
save_status()andsend_notifications()into if/else branches. Ephemeral jobs skip status write (wasted I/O since directory is deleted) but still send notifications. Recurring jobs get both. Closes #117.No suggestions.