thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(notifications): add SMTP_SSL support for implicit TLS #154

Merged
fuzzy merged 1 commit from fix/0119-smtp-ssl-support into main 2026-07-05 18:07:05 +00:00
Conversation 1 Commits 1 Files changed 3 +38 -5
automation commented 2026-07-05 18:02:31 +00:00
Owner
Copy link

What

Add smtp_use_ssl config flag to NotificationConfig. When True, uses smtplib.SMTP_SSL (port 465 implicit TLS) instead of smtplib.SMTP with STARTTLS (port 587).

Why

Many SMTP providers (e.g. SendGrid, Mailgun) require implicit TLS on port 465 which wasn't supported.

Testing

  • 146 unit tests pass (1 new: test_sends_smtp_ssl)
  • Pre-commit hooks pass

Closes #119

## What Add `smtp_use_ssl` config flag to `NotificationConfig`. When `True`, uses `smtplib.SMTP_SSL` (port 465 implicit TLS) instead of `smtplib.SMTP` with STARTTLS (port 587). ## Why Many SMTP providers (e.g. SendGrid, Mailgun) require implicit TLS on port 465 which wasn't supported. ## Testing - [x] 146 unit tests pass (1 new: test_sends_smtp_ssl) - [x] Pre-commit hooks pass Closes #119
feat(notifications): add SMTP_SSL support for implicit TLS
All checks were successful
CI / test (pull_request) Successful in 53s
Details
CI / lint (pull_request) Successful in 1m23s
Details
c6caf09d88 
Adds smtp_use_ssl config flag (default False). When True, uses
smtplib.SMTP_SSL (port 465) instead of smtplib.SMTP with STARTTLS.
Closes #119
the.auditor approved these changes 2026-07-05 18:06:56 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #154

Result: APPROVED

Clean feature addition — adds smtp_use_ssl config flag. When True, uses SMTP_SSL (port 465, implicit TLS); when False (default), uses SMTP with starttls() (port 587). Config field, test, and wiring all included. Closes #119.

No suggestions.

## Automated Review — PR #154 **Result: APPROVED** --- Clean feature addition — adds `smtp_use_ssl` config flag. When True, uses `SMTP_SSL` (port 465, implicit TLS); when False (default), uses `SMTP` with `starttls()` (port 587). Config field, test, and wiring all included. Closes #119. No suggestions.
fuzzy merged commit c6caf09d88 into main 2026-07-05 18:07:05 +00:00
fuzzy deleted branch fix/0119-smtp-ssl-support 2026-07-05 18:07:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!154
No description provided.