thwap/kronai

Watch

Fork 0

feat(project): define project structure #72

Merged

fuzzy merged 10 commits from feature/0004-define-project-structure into main

2026-07-05 13:28:59 +00:00

automation commented

2026-07-05 12:35:43 +00:00

Owner

What

Define the project directory layout, Python module structure, and dependency files for the KronAI project.

Why

Establishes the foundational project structure needed for all subsequent Phase 1 tasks.

Testing

Unit tests pass
Pre-commit hooks pass (ruff, mypy, formatting)
Integration tests pass (N/A - scaffold phase)

Breaking Changes

None.

Notes

Sets up src/kronai/ package with core module stubs (type hints + docstrings), tests/unit/ and tests/integration/ directories, and dependency files.

Closes #0001
Closes #0002
Closes #0003
Closes #0004

## What Define the project directory layout, Python module structure, and dependency files for the KronAI project. ## Why Establishes the foundational project structure needed for all subsequent Phase 1 tasks. ## Testing - [x] Unit tests pass - [x] Pre-commit hooks pass (ruff, mypy, formatting) - [ ] Integration tests pass (N/A - scaffold phase) ## Breaking Changes None. ## Notes Sets up `src/kronai/` package with core module stubs (type hints + docstrings), `tests/unit/` and `tests/integration/` directories, and dependency files. Closes #0001 Closes #0002 Closes #0003 Closes #0004

automation added 4 commits

2026-07-05 12:35:43 +00:00

feat(project): create directory layout per spec dc96fc6a05

Add unit and integration test directories, and scripts directory.
Closes #0001

feat(project): set up Python module structure c852588443

Add core modules: config, discovery, engine, llm, mcp, cli, models,
exceptions, utils. Each module has docstrings and type hints.
Closes #0002

chore: add dependency files for virtual environment b504fc23f3

- requirements.txt for production install
- requirements-dev.txt for development dependencies
Closes #0003

docs: mark Phase 1 Task 1 complete

CI / test (pull_request) Failing after 9s

Details

CI / lint (pull_request) Failing after 9s

Details

d0949a7fa7

Define project structure and all sub-tasks done.
Closes #0004

fuzzy added 1 commit

2026-07-05 12:39:00 +00:00

ci: use Python 3.11 for arm64 compatibility

CI / lint (pull_request) Failing after 7s

Details

CI / test (pull_request) Failing after 7s

Details

4a6b306689

3.12 prebuilt not available for arm64 runners. Switch to 3.11.

fuzzy added 1 commit

2026-07-05 12:40:34 +00:00

ci: replace setup-python with apt for arm64 support

CI / lint (pull_request) Failing after 5s

Details

CI / test (pull_request) Failing after 5s

Details

0de3a089a0

actions/setup-python has no prebuilt binaries for arm64.
Use system apt packages instead.

fuzzy added 1 commit

2026-07-05 13:02:17 +00:00

ci: remove sudo not present on runner

CI / lint (pull_request) Failing after 16s

Details

CI / test (pull_request) Failing after 16s

Details

a6f52e688f

fuzzy added 1 commit

2026-07-05 13:04:03 +00:00

ci: use venv to bypass PEP 668 external env protection

CI / lint (pull_request) Successful in 1m10s

Details

CI / test (pull_request) Failing after 45s

Details

923946e784

fuzzy added 1 commit

2026-07-05 13:12:40 +00:00

fix: lower coverage threshold to 0.5% for scaffold phase

CI / lint (pull_request) Successful in 1m12s

Details

CI / test (pull_request) Failing after 51s

Details

a40bf42954

fuzzy added 1 commit

2026-07-05 13:16:33 +00:00

ci: remove upload-artifact step (not supported on GHES)

CI / lint (pull_request) Successful in 1m10s

Details

CI / test (pull_request) Successful in 45s

Details

a0537696ac

the.auditor reviewed

2026-07-05 13:27:17 +00:00

the.auditor left a comment

Automated Review — PR #72

Result: COMMENT (no blocking issues found; suggestions and questions below)

Suggestions

src/kronai/mcp.py:24,40 — Docstring format inconsistency. Raises and Returns section headers missing trailing colon. Rest of codebase uses Raises: / Returns: (numpy-style). Ruff D416 will flag this.
src/kronai/llm.py:38 — **kwargs: float too restrictive. OpenAI-compatible clients pass non-float params like stop (list[str]), top_p, etc. Suggest **kwargs: Any or a TypedDict.
src/kronai/mcp.py:39 — get_tools return type list[dict[str, str]] likely too narrow. MCP tool definitions include nested inputSchema dicts. Consider list[dict[str, Any]].
pyproject.toml — fail_under = 0.5 is functionally a waiver. Fine for scaffold, but add a TODO to raise once implementation starts.

Questions

.forgejo/workflows/ci.yml — upload-artifact@v4 for coverage HTML was removed. Intentional?

## Automated Review — PR #72 **Result: COMMENT** (no blocking issues found; suggestions and questions below) --- ### Suggestions 1. **`src/kronai/mcp.py:24,40`** — Docstring format inconsistency. `Raises` and `Returns` section headers missing trailing colon. Rest of codebase uses `Raises:` / `Returns:` (numpy-style). Ruff D416 will flag this. 2. **`src/kronai/llm.py:38`** — `**kwargs: float` too restrictive. OpenAI-compatible clients pass non-float params like `stop` (list[str]), `top_p`, etc. Suggest `**kwargs: Any` or a TypedDict. 3. **`src/kronai/mcp.py:39`** — `get_tools` return type `list[dict[str, str]]` likely too narrow. MCP tool definitions include nested `inputSchema` dicts. Consider `list[dict[str, Any]]`. 4. **`pyproject.toml`** — `fail_under = 0.5` is functionally a waiver. Fine for scaffold, but add a TODO to raise once implementation starts. ### Questions 5. **`.forgejo/workflows/ci.yml`** — `upload-artifact@v4` for coverage HTML was removed. Intentional?

fuzzy commented

2026-07-05 13:28:17 +00:00

Owner

Yes coverage was removed so that CI would pass until actual code was in there to be able to enforce the requirement.

the.auditor approved these changes

2026-07-05 13:28:43 +00:00

the.auditor left a comment

Correcting my review — no blocking issues, so this is an approval. Suggestions from previous review still stand (docstring format, kwargs type, mcp return type, fail_under TODO).

fuzzy merged commit a0537696ac into main

2026-07-05 13:28:59 +00:00

fuzzy deleted branch feature/0004-define-project-structure

2026-07-05 13:28:59 +00:00