feat(engine): implement prompt reader #81

Merged

fuzzy merged 3 commits from feature/0017-implement-prompt-reader into main

2026-07-05 13:53:15 +00:00

automation commented

2026-07-05 13:50:39 +00:00

Owner

What

Implement prompt reader that reads prompt.md from job directories and raises JobError on missing/unreadable prompts.

Why

Foundation for job execution - the LLM client needs a prompt to process.

Testing

44 unit tests pass (5 new for prompt reader)
Pre-commit hooks pass
Coverage: 76%

Breaking Changes

None.

Closes #0015
Closes #0016
Closes #0017

## What Implement prompt reader that reads `prompt.md` from job directories and raises `JobError` on missing/unreadable prompts. ## Why Foundation for job execution - the LLM client needs a prompt to process. ## Testing - [x] 44 unit tests pass (5 new for prompt reader) - [x] Pre-commit hooks pass - [x] Coverage: 76% ## Breaking Changes None. Closes #0015 Closes #0016 Closes #0017

automation added 3 commits

2026-07-05 13:50:39 +00:00

feat(engine): implement prompt reader 55d563cf1c

Read prompt.md from job directories with proper error handling
for missing or unreadable files.
Closes #0015
Closes #0016

test(engine): add prompt reader unit tests c6c4e08d11

Cover successful reads, multiline content, missing prompt,
empty directory, and nonexistent path.

docs: mark Phase 2 Task 1 complete

CI / test (pull_request) Successful in 52s

Details

CI / lint (pull_request) Successful in 1m20s

Details

3512fd48c5

Prompt reader with error handling for missing prompts done.
Closes #0017

the.auditor approved these changes

2026-07-05 13:52:38 +00:00

the.auditor left a comment

Automated Review — PR #81

Result: APPROVED

Small, focused PR. The read_prompt() function is correct and well-tested.

Correctness: Existence check before read, JobError on missing/unreadable, proper encoding, exception chaining with from e.
Completeness: Closes #15–#17. ROADMAP updated.
Test coverage: 5 tests covering present, multiline, missing, and nonexistent paths.
Error handling: JobError for both missing file and OSError on read.

Suggestions (non-blocking)

tests/unit/test_prompt.py:4-12 — Import style inconsistency. Path is imported under TYPE_CHECKING while the rest of the test suite (test_config.py, test_discovery.py) imports it at module level. Also, from kronai... imports placed after the TYPE_CHECKING block differs from the project convention (real imports first, TYPE_CHECKING last). Minor, but worth aligning.
src/kronai/engine.py:32 — msg = f"Prompt file not found in {job_path}" includes the full path in the error message. Same path-leakage concern as issue #74 — consider using job_path.name if logging user-visible paths is a concern.

## Automated Review — PR #81 **Result: APPROVED** --- Small, focused PR. The `read_prompt()` function is correct and well-tested. - **Correctness**: Existence check before read, `JobError` on missing/unreadable, proper encoding, exception chaining with `from e`. - **Completeness**: Closes #15–#17. ROADMAP updated. - **Test coverage**: 5 tests covering present, multiline, missing, and nonexistent paths. - **Error handling**: `JobError` for both missing file and OSError on read. ### Suggestions (non-blocking) 1. **`tests/unit/test_prompt.py:4-12`** — Import style inconsistency. `Path` is imported under `TYPE_CHECKING` while the rest of the test suite (`test_config.py`, `test_discovery.py`) imports it at module level. Also, `from kronai...` imports placed after the `TYPE_CHECKING` block differs from the project convention (real imports first, TYPE_CHECKING last). Minor, but worth aligning. 2. **`src/kronai/engine.py:32`** — `msg = f"Prompt file not found in {job_path}"` includes the full path in the error message. Same path-leakage concern as issue #74 — consider using `job_path.name` if logging user-visible paths is a concern.

the.auditor referenced this pull request

2026-07-05 13:52:54 +00:00

engine: align test_prompt.py import style with rest of test suite #82

the.auditor referenced this pull request

2026-07-05 13:52:55 +00:00

engine: read_prompt error message leaks full job path #83

fuzzy merged commit 3512fd48c5 into main

2026-07-05 13:53:15 +00:00

fuzzy deleted branch feature/0017-implement-prompt-reader

2026-07-05 13:53:16 +00:00