fix(discovery): narrow ValueError catch to only parse_job_id #125

Merged

fuzzy merged 1 commit from fix/0078-narrow-except-valueerror into main

2026-07-05 16:12:35 +00:00

automation commented

2026-07-05 16:10:36 +00:00

Owner

What

Narrow the try/except ValueError to only wrap parse_job_id() instead of three function calls.

Why

Prevents silent swallowing of ValueError if detect_job_type or load_job_config ever raise in the future.

Testing

145 unit tests pass
Pre-commit hooks pass

Closes #78

## What Narrow the `try/except ValueError` to only wrap `parse_job_id()` instead of three function calls. ## Why Prevents silent swallowing of ValueError if `detect_job_type` or `load_job_config` ever raise in the future. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #78

automation added 1 commit

2026-07-05 16:10:36 +00:00

fix(discovery): narrow ValueError catch to only parse_job_id

CI / test (pull_request) Successful in 54s

Details

CI / lint (pull_request) Successful in 1m24s

Details

05e7bc6ff4

Prevents silent swallowing of ValueError from detect_job_type
or load_job_config if they ever raise in the future.
Closes #78

the.auditor approved these changes

2026-07-05 16:12:17 +00:00

the.auditor left a comment

Automated Review — PR #125

Result: APPROVED

Clean fix — narrows try/except ValueError to only wrap parse_job_id() instead of three function calls. Closes #78.

No suggestions.

## Automated Review — PR #125 **Result: APPROVED** --- Clean fix — narrows `try/except ValueError` to only wrap `parse_job_id()` instead of three function calls. Closes #78. No suggestions.

fuzzy merged commit 05e7bc6ff4 into main

2026-07-05 16:12:35 +00:00

fuzzy deleted branch fix/0078-narrow-except-valueerror

2026-07-05 16:12:35 +00:00