fix(discovery): catch ConfigError per-job in discover_jobs #127

Merged
fuzzy merged 1 commit from fix/0080-handle-invalid-job-config into main 2026-07-05 16:24:12 +00:00
Owner

What

Wrap load_job_config in try/except ConfigError per-job so that an invalid config.toml in one job doesn't halt discovery of all other jobs.

Why

One bad config should not block everything — it falls back to defaults and continues.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #80

## What Wrap `load_job_config` in `try/except ConfigError` per-job so that an invalid `config.toml` in one job doesn't halt discovery of all other jobs. ## Why One bad config should not block everything — it falls back to defaults and continues. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #80
fix(discovery): catch ConfigError per-job in discover_jobs
All checks were successful
CI / test (pull_request) Successful in 48s
CI / lint (pull_request) Successful in 1m24s
04398e7f97
Invalid config.toml in one job no longer halts discovery of all
jobs. Falls back to defaults with a warning.
Closes #80
the.auditor left a comment

Automated Review — PR #127

Result: APPROVED


Clean fix — wraps load_job_config() in try/except ConfigError per-job, falling back to JobConfig() defaults with a warning. Prevents one bad config from blocking discovery of all other jobs. Closes #80.

No suggestions.

## Automated Review — PR #127 **Result: APPROVED** --- Clean fix — wraps `load_job_config()` in `try/except ConfigError` per-job, falling back to `JobConfig()` defaults with a warning. Prevents one bad config from blocking discovery of all other jobs. Closes #80. No suggestions.
fuzzy merged commit 04398e7f97 into main 2026-07-05 16:24:12 +00:00
fuzzy deleted branch fix/0080-handle-invalid-job-config 2026-07-05 16:24:12 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!127
No description provided.