thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(mcp): validate initialize handshake response for required fields #135

Merged
fuzzy merged 1 commit from fix/0092-mcp-validate-initialize into main 2026-07-05 16:48:19 +00:00
Conversation 1 Commits 1 Files changed 2 +19 -6
automation commented 2026-07-05 16:43:05 +00:00
Owner
Copy link

What

Add validation to _send_initialize() to check that the response contains serverInfo and protocolVersion. Raises MCPError if either is missing.

Why

Previously, an unexpected initialize response (e.g. empty result) would silently continue, potentially causing confusing errors later.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #92

## What Add validation to `_send_initialize()` to check that the response contains `serverInfo` and `protocolVersion`. Raises `MCPError` if either is missing. ## Why Previously, an unexpected initialize response (e.g. empty result) would silently continue, potentially causing confusing errors later. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #92
fix(mcp): validate initialize handshake response for required fields
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
e2b1c40535 
Check that serverInfo and protocolVersion are present in the
initialize response, raising MCPError if not.
Closes #92
fuzzy self-assigned this 2026-07-05 16:43:41 +00:00
fuzzy force-pushed fix/0092-mcp-validate-initialize from e2b1c40535
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
to db8567aa15
All checks were successful
CI / test (pull_request) Successful in 52s
Details
CI / lint (pull_request) Successful in 1m24s
Details
2026-07-05 16:43:47 +00:00 Compare
fuzzy force-pushed fix/0092-mcp-validate-initialize from db8567aa15
All checks were successful
CI / test (pull_request) Successful in 52s
Details
CI / lint (pull_request) Successful in 1m24s
Details
to 42956fc13a
All checks were successful
CI / lint (pull_request) Successful in 1m21s
Details
CI / test (pull_request) Successful in 51s
Details
2026-07-05 16:46:08 +00:00 Compare
the.auditor approved these changes 2026-07-05 16:46:22 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #135

Result: APPROVED

Clean fix — validates _send_initialize() response for serverInfo and protocolVersion fields, raises MCPError if either is missing. Tests updated to include protocolVersion in mock responses. Closes #92.

No suggestions.

## Automated Review — PR #135 **Result: APPROVED** --- Clean fix — validates `_send_initialize()` response for `serverInfo` and `protocolVersion` fields, raises `MCPError` if either is missing. Tests updated to include `protocolVersion` in mock responses. Closes #92. No suggestions.
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-05 16:46:37 +00:00
fuzzy merged commit 42956fc13a into main 2026-07-05 16:48:19 +00:00
fuzzy deleted branch fix/0092-mcp-validate-initialize 2026-07-05 16:48:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
fuzzy
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!135
No description provided.