thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(engine): log warning when ephemeral directory deletion fails #138

Merged
fuzzy merged 1 commit from fix/0096-ephemeral-deletion-logging into main 2026-07-05 16:55:31 +00:00
Conversation 1 Commits 1 Files changed 1 +9 -1
automation commented 2026-07-05 16:53:34 +00:00
Owner
Copy link

What

Replace shutil.rmtree(ignore_errors=True) with explicit try/except OSError that logs a warning when ephemeral directory deletion fails.

Why

ignore_errors=True silently swallows all errors (permission, read-only, etc.), making failures invisible.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #96

## What Replace `shutil.rmtree(ignore_errors=True)` with explicit `try/except OSError` that logs a warning when ephemeral directory deletion fails. ## Why `ignore_errors=True` silently swallows all errors (permission, read-only, etc.), making failures invisible. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #96
fix(engine): log warning when ephemeral directory deletion fails
All checks were successful
CI / test (pull_request) Successful in 47s
Details
CI / lint (pull_request) Successful in 1m20s
Details
88be67fd6e 
Replaced shutil.rmtree(ignore_errors=True) with explicit
try/except that logs a warning on failure.
Closes #96
the.auditor approved these changes 2026-07-05 16:55:17 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #138

Result: APPROVED

Clean fix — replaces silent shutil.rmtree(ignore_errors=True) with explicit try/except OSError that logs a warning. Failures are now visible in logs. Closes #96.

No suggestions.

## Automated Review — PR #138 **Result: APPROVED** --- Clean fix — replaces silent `shutil.rmtree(ignore_errors=True)` with explicit `try/except OSError` that logs a warning. Failures are now visible in logs. Closes #96. No suggestions.
fuzzy merged commit 88be67fd6e into main 2026-07-05 16:55:31 +00:00
fuzzy deleted branch fix/0096-ephemeral-deletion-logging 2026-07-05 16:55:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!138
No description provided.